GNU bug report logs - #52568
[PATCH] gnu: ableton-link: Run tests conditionally.

Previous Next

Package: guix-patches;

Reported by: Aleksandr Vityazev <avityazev <at> posteo.org>

Date: Fri, 17 Dec 2021 08:31:01 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52568 in the body.
You can then email your comments to 52568 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#52568; Package guix-patches. (Fri, 17 Dec 2021 08:31:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Aleksandr Vityazev <avityazev <at> posteo.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 17 Dec 2021 08:31:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ableton-link: Run tests conditionally.
Date: Fri, 17 Dec 2021 08:30:24 +0000

* gnu/packages/audio.scm (ableton-link)[arguments]: Respect TESTS? option.
---
 gnu/packages/audio.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index f5fda6d4e9..beae167fb3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5245,11 +5245,12 @@ (define-public ableton-link
        #:phases
        (modify-phases %standard-phases
          (replace 'check
-           (lambda* (#:key inputs #:allow-other-keys)
-             (let* ((python (search-input-file inputs "/bin/python3"))
-                    (run-tests "../source/ci/run-tests.py"))
-               (invoke python run-tests "--target" "LinkCoreTest")
-               (invoke python run-tests "--target" "LinkDiscoveryTest"))))
+           (lambda* (#:key inputs tests? #:allow-other-keys)
+             (when tests?
+               (let* ((python (search-input-file inputs "/bin/python3"))
+                      (run-tests "../source/ci/run-tests.py"))
+                 (invoke python run-tests "--target" "LinkCoreTest")
+                 (invoke python run-tests "--target" "LinkDiscoveryTest")))))
          (add-before 'install 'patch-cmake
            (lambda* (#:key inputs #:allow-other-keys)
              (let* ((source "../source/"))
-- 
2.34.0



-- 

Aleksandr Vityazev
Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Fri, 17 Dec 2021 08:37:02 GMT) Full text and rfc822 format available.
Notification sent to Aleksandr Vityazev <avityazev <at> posteo.org>:
bug acknowledged by developer. (Fri, 17 Dec 2021 08:37:02 GMT) Full text and rfc822 format available.

Message #10 received at 52568-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 52568-done <at> debbugs.gnu.org
Subject: Re: [bug#52568] [PATCH] gnu: ableton-link: Run tests conditionally.
Date: Fri, 17 Dec 2021 09:35:58 +0100

Hello,

Aleksandr Vityazev <avityazev <at> posteo.org> writes:

> * gnu/packages/audio.scm (ableton-link)[arguments]: Respect TESTS?
> option.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 14 Jan 2022 12:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 156 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.