GNU bug report logs - #52336
[PATCH 1/2] gnu: register notcurses.scm in local.mk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 52336 in the body.
You can then email your comments to 52336 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Blake Shaw <blake <at> nonconstructivism.com>
To: guix-patches <at> gnu.org
Cc: Blake Shaw <blake <at> nonconstructivism.com>
Subject: [PATCH 1/2] gnu: register notcurses.scm in local.mk
Date: Tue,  7 Dec 2021 02:00:01 +0700

---
 gnu/local.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/local.mk b/gnu/local.mk
index b91d6eaa62..54e6dd422d 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -422,6 +422,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/ninja.scm			\
   %D%/packages/node.scm				\
   %D%/packages/node-xyz.scm			\
+  %D%/packages/notcurses.scm			\
   %D%/packages/noweb.scm			\
   %D%/packages/nss.scm				\
   %D%/packages/ntp.scm				\
-- 
2.33.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Blake Shaw via Guix-patches via <guix-patches <at> gnu.org>
Cc: 52336 <at> debbugs.gnu.org, Blake Shaw <blake <at> nonconstructivism.com>
Subject: Re: [bug#52336] [PATCH 1/2] gnu: register notcurses.scm in local.mk
Date: Mon, 6 Dec 2021 14:24:11 -0500

On Tue, Dec 07, 2021 at 02:00:01AM +0700, Blake Shaw via Guix-patches via wrote:
> ---
>  gnu/local.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index b91d6eaa62..54e6dd422d 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -422,6 +422,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ninja.scm			\
>    %D%/packages/node.scm				\
>    %D%/packages/node-xyz.scm			\
> +  %D%/packages/notcurses.scm			\

Thanks! Remember, this should be done in the same commit as adding the
new file itself. Otherwise, the build of Guix would be broken in between
the two commits.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Blake Shaw <blake <at> nonconstructivism.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 52336 <at> debbugs.gnu.org,
 Blake Shaw via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#52336] [PATCH 1/2] gnu: register notcurses.scm in local.mk
Date: Wed, 22 Dec 2021 03:37:10 +0700

Leo Famulari <leo <at> famulari.name> writes:

> Thanks! Remember, this should be done in the same commit as adding the
> new file itself. Otherwise, the build of Guix would be broken in between
> the two commits.

sorry Leo did you need me to rebase these commits before the package can
be merged?

-- 
“In girum imus nocte et consumimur igni”

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Blake Shaw <blake <at> nonconstructivism.com>
Cc: 52336 <at> debbugs.gnu.org,
 Blake Shaw via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#52336] [PATCH 1/2] gnu: register notcurses.scm in local.mk
Date: Tue, 21 Dec 2021 15:51:34 -0500

On Wed, Dec 22, 2021 at 03:37:10AM +0700, Blake Shaw wrote:
> sorry Leo did you need me to rebase these commits before the package can
> be merged?

Can you clarify what this patch is for?

It looks like ticket #52336 only registers a package module in
'gnu/local.mk', but the actual patch adding the module is missing:

https://issues.guix.gnu.org/52336

I sent my earlier message assuming that there would also be a commit
adding notcurses.scm itself.

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Blake Shaw <blake <at> nonconstructivism.com>
Cc: 52336 <at> debbugs.gnu.org,
 Blake Shaw via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: [bug#52336] [PATCH 1/2] gnu: register notcurses.scm in local.mk
Date: Tue, 21 Dec 2021 18:23:18 -0500

On Tue, Dec 21, 2021 at 03:51:34PM -0500, Leo Famulari wrote:
> It looks like ticket #52336 only registers a package module in
> 'gnu/local.mk', but the actual patch adding the module is missing:
> 
> https://issues.guix.gnu.org/52336

Oh, I see. The other patch is #52335. I've merged the two tickets now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.