GNU bug report logs - #52062
[PATCH] gnu: system: Make old-style swap use default flags

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: bug#52062: closed (Re: [PATCH] gnu: system: Make old-style swap
 use default flags)
Date: Tue, 23 Nov 2021 18:09:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#52062: [PATCH] gnu: system: Make old-style swap use default flags

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 52062 <at> debbugs.gnu.org.

-- 
52062: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52062
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: dev <at> jpoiret.xyz, 52062-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: system: Make old-style swap use default flags
Date: Tue, 23 Nov 2021 18:08:46 +0000

Pushed as d48b404cf577cbfcd29b294e193a4db0c3e580b1 by Tobias.

Sorry for this omission, I wonder how that got past my tests.  Maybe
`guix system vm` removes swap-devices?

Best,
Josselin Poiret

[Message part 3 (message/rfc822, inline)]

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: guix-patches <at> gnu.org
Cc: Josselin Poiret <dev <at> jpoiret.xyz>
Subject: [PATCH] gnu: system: Make old-style swap use default flags
Date: Tue, 23 Nov 2021 17:56:46 +0000

* gnu/services/base.scm (swap-service-type): Fix it.
---
 gnu/services/base.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 20736eb13f..ba01f5d764 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2225,8 +2225,10 @@ (define device-lookup
                      (and device
                           (begin
                             (restart-on-EINTR (swapon device
-                                                      #$(swap-space->flags-bit-mask
-                                                         swap)))
+                                                      #$(if (swap-space? swap)
+                                                            (swap-space->flags-bit-mask
+                                                             swap)
+                                                            0)))
                             #t)))))
         (stop #~(lambda _
                   (let ((device #$device-lookup))
-- 
2.33.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.