GNU bug report logs - #51989
[PATCH 00/12] Add aws-vault and missing dependent packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#51989: closed ([PATCH 00/12] Add aws-vault and missing
 dependent packages)
Date: Fri, 31 Dec 2021 17:25:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 31 Dec 2021 18:24:40 +0100
with message-id <87pmpcpu07.fsf <at> gnu.org>
and subject line Re: bug#51989: [PATCH 00/12] Add aws-vault and missing dependent packages
has caused the debbugs.gnu.org bug report #51989,
regarding [PATCH 00/12] Add aws-vault and missing dependent packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
51989: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=51989
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH 00/12] Add aws-vault and missing dependent packages
Date: Fri, 19 Nov 2021 18:12:54 -0500

aws-vault is a tool to securely store and use aws credentials. This patch set packages aws-vault as well as missing dependencies.

Note: perhaps gnu/packages/golang.scm is not the best fit for these changes. Any suggestions for a better spot appreciated.

Collin J. Doering (12):
  gnu: Add go-keyring
  gnu: Add go-androidnsfix
  gnu: Add go-percent
  gnu: Add go-aws-sdk-go
  gnu: Add go-jose2go
  gnu: Add go-libsecret
  gnu: Add go-ini
  gnu: Add go-open-golang
  gnu: Add go-alecthomas-template
  gnu: Add go-alecthomas-units
  gnu: Add go-kingpin
  gnu: Add aws-vault

 gnu/packages/golang.scm | 380 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 380 insertions(+)

-- 
2.33.1

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Collin J. Doering" <collin <at> rekahsoft.ca>
Cc: 51989-done <at> debbugs.gnu.org
Subject: Re: bug#51989: [PATCH 00/12] Add aws-vault and missing dependent
 packages
Date: Fri, 31 Dec 2021 18:24:40 +0100

Hi Collin,

I’ve applied the second version of this patch set that you sent on
Monday.  I fixed a couple of version strings that still had the “v”
prefix and tweaked synopses/descriptions following these guidelines:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

"Collin J. Doering" <collin <at> rekahsoft.ca> skribis:

[...]

>>   2. As you go, could you pass them to:
>> ./pre-inst-env guix style PKG
>> ?
>>
>
> I actually had issues doing this. The above command would
> segfault. After running the `clean` and `clean-go` make targets, it
> would no longer segfault, but would then complain about ABI
> compatibility. I didn't debug further instead ran the
> `etc/indent-code.el` source file, commiting as necessary. However, I
> did find that after rebasing my changes onto the tip of master, the
> `guix style` command started to work as expected.
>
> Another note: I use emacs and did load the `.dir-locals.el` file when
> making these changes, so I would have expected formatting to be fine
> already. Must be something on my end that is affecting auto-formatting
> in emacs.

With ‘.dir-locals.el’, I expect Emacs should do the right thing.

However, what Emacs cannot do is convert to the “simplified input
style”, which is what ‘guix style’ does.  (Eventually ‘indent-code.el’
functionality will be replaced by ‘guix style’ too.)

A segfault sounds scary, it could have been a setup issue somehow; we
can investigate next time!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.