GNU bug report logs - #51988
[PATCH] Implement the buttonForeground resource color

Previous Next

Package: emacs;

Reported by: Gregory Heytings <gregory <at> heytings.org>

Date: Fri, 19 Nov 2021 23:08:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51988 in the body.
You can then email your comments to 51988 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#51988; Package emacs. (Fri, 19 Nov 2021 23:08:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Gregory Heytings <gregory <at> heytings.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 19 Nov 2021 23:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Implement the buttonForeground resource color
Date: Fri, 19 Nov 2021 23:07:53 +0000

[Message part 1 (text/plain, inline)]
The manual documents, in Lucid Resources, a "buttonForeground" resource 
color, which is read and allocated, but never actually used.  Patch 
attached, and a screenshot without and with the patch.  Without the patch, 
selected items are hard to differentiate from unselected ones, with the 
patch and without setting that resource color they become visibly 
different.
[Implement-the-buttonForeground-resource.patch (text/x-diff, attachment)]
[without-patch.png (image/png, attachment)]
[with-patch.png (image/png, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51988; Package emacs. (Sat, 20 Nov 2021 00:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 51988 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: 51988 <at> debbugs.gnu.org
Subject: Re: bug#51988: [PATCH] Implement the buttonForeground resource color
Date: Sat, 20 Nov 2021 00:24:02 +0000

[Message part 1 (text/plain, inline)]
Slightly improved patch attached.
[Implement-the-buttonForeground-resource.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#51988; Package emacs. (Sat, 20 Nov 2021 09:38:01 GMT) Full text and rfc822 format available.

Message #11 received at 51988 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 51988 <at> debbugs.gnu.org
Subject: Re: bug#51988: [PATCH] Implement the buttonForeground resource color
Date: Sat, 20 Nov 2021 10:37:31 +0100

Gregory Heytings <gregory <at> heytings.org> writes:

> Slightly improved patch attached.

Looks good to me; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug marked as fixed in version 29.1, send any further explanations to 51988 <at> debbugs.gnu.org and Gregory Heytings <gregory <at> heytings.org> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sat, 20 Nov 2021 09:38:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 Dec 2021 12:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 243 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.