GNU bug report logs - #51989
[PATCH 00/12] Add aws-vault and missing dependent packages

Previous Next

Full log

View this message in rfc822 format

From: "Collin J. Doering" <collin <at> rekahsoft.ca>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 51989 <at> debbugs.gnu.org
Subject: [bug#51989] [PATCH 00/12] Add aws-vault and missing dependent packages
Date: Mon, 27 Dec 2021 14:30:16 -0500

[Message part 1 (text/plain, inline)]

Hi Ludovic,

Apologies, I realized after the fact that you not only wanted formatting applied, but also adjust made for the upcoming big change (as noted on the guix blog). As such, please disregard my last patch set. The one below is appropriately formatted with the style command as suggested.

Kind regards,

[aws-vault-and-deps.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

On 27 Dec 2021 at 11:19, "Collin J. Doering" <collin <at> rekahsoft.ca> wrote:

> Hi Ludovic,
>
> Thank you for getting back to me.
>
>> Hi Collin,
>>
>> "Collin J. Doering" <collin <at> rekahsoft.ca> skribis:
>>
>>> aws-vault is a tool to securely store and use aws credentials. This patch set packages aws-vault as well as missing dependencies.
>>>
>>> Note: perhaps gnu/packages/golang.scm is not the best fit for these changes. Any suggestions for a better spot appreciated.
>>
>> Hmm not sure; most of the dependencies are at home in golang.scm IMO.
>> I’d leave it as is.
>>
>>> Collin J. Doering (12):
>>>   gnu: Add go-keyring
>>>   gnu: Add go-androidnsfix
>>>   gnu: Add go-percent
>>>   gnu: Add go-aws-sdk-go
>>>   gnu: Add go-jose2go
>>>   gnu: Add go-libsecret
>>>   gnu: Add go-ini
>>>   gnu: Add go-open-golang
>>>   gnu: Add go-alecthomas-template
>>>   gnu: Add go-alecthomas-units
>>>   gnu: Add go-kingpin
>>>   gnu: Add aws-vault
>>
>> I tried to apply those (overall it LGTM), but the order is incorrect:
>> for instance ‘go-keyring’ depends on ‘go-percent’ and ‘go-libsecret’.
>>
>> So I have the following queries:
>>
>>   1. Do you think you could send them in the “right order”?
>>
>
> Done (see new patch set attached to this email).
>
>>   2. As you go, could you pass them to:
>>
>>       ./pre-inst-env guix style PKG
>>
>>      ?
>>
>
> I actually had issues doing this. The above command would segfault. After running the `clean`
> and `clean-go` make targets, it would no longer segfault, but would then complain about ABI
> compatibility. I didn't debug further instead ran the `etc/indent-code.el` source file,
> commiting as necessary. However, I did find that after rebasing my changes onto the tip of
> master, the `guix style` command started to work as expected.
>
> Another note: I use emacs and did load the `.dir-locals.el` file when making these changes,
> so I would have expected formatting to be fine already. Must be something on my end that is
> affecting auto-formatting in emacs.
>
>>   3. Last, it would be perfect if you could provide the conventional
>>      commit logs.
>>
>
> Done. Please let me know if the new logs provided match the expected conventions.
>
>> Thanks in advance, and sorry for the delay!
>>
>> Ludo’.
>
> Thank you again for your consideration and time reviewing this patchset.
>
> Kind regards,
>
> [2. text/x-patch; aws-vault-and-deps.patch]...


-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.