GNU bug report logs - #51451
image-transform-original has a misleading name

Previous Next

Full log

Message #20 received at 51451 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: 51451 <at> debbugs.gnu.org
Subject: Re: bug#51451: image-transform-original has a misleading name
Date: Wed, 3 Nov 2021 13:16:55 -0700

Juri Linkov <juri <at> linkov.net> writes:

>>> image-transform-* commands are modifying the values of
>>> image-transform-* variables.
>>> Would you propose to rename variables as well?
>>
>> I didn't think about that, as the commands are what the user will see.
>> Maybe we should.  Do you think it would be a good idea?
>
> At least, currently there is consistency in naming of
> image-transform-* functions and variables.

That's true.

> But if you see a problem only in the name of image-transform-original,
> then it could be renamed to image-transform-set-original or maybe
> better to image-transform-reset-to-original, i.e. to something more
> descriptive, while keeping the existing name prefix.

I see a problem with all of them, especially in combination with
`image-save'.  :-(

But the most confusing one by far is `image-transform-original', indeed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.