GNU bug report logs - #51450
Bugs in gnus-short-group-name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51450 in the body.
You can then email your comments to 51450 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: bug-gnu-emacs <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: Bugs in gnus-short-group-name
Date: Wed, 27 Oct 2021 17:59:04 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

---
 test/lisp/gnus/gnus-tests.el | 39 ++++++++++++++++++++++++++++--------
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/test/lisp/gnus/gnus-tests.el b/test/lisp/gnus/gnus-tests.el
index 6602e67a34..f96b584064 100644
--- a/test/lisp/gnus/gnus-tests.el
+++ b/test/lisp/gnus/gnus-tests.el
@@ -1,4 +1,4 @@
-;;; gnus-tests.el --- Wrapper for the Gnus tests  -*- lexical-binding:t -*-
+;;; gnus-tests.el --- Gnus tests  -*- lexical-binding:t -*-
 
 ;; Copyright (C) 2011-2021 Free Software Foundation, Inc.
 
@@ -21,13 +21,36 @@
 
 ;;; Commentary:
 
-;; This file should contain nothing but requires for all the Gnus
-;; tests that are not standalone.
-
 ;;; Code:
-;; registry.el is required by gnus-registry.el but this way we're explicit.
-(require 'registry)
-(require 'gnus-registry)
+(require 'gnus)
+
+;; TODO: test with optional LEVELS argument
+(ert-deftest gnus-short-group-name ()
+  (map-apply
+   (lambda (input expected)
+     (should (string-equal (gnus-short-group-name input) expected)))
+   '(
+     ;; I think these are correct and nice and good
+     ("nnimap+email <at> example.com:archives/2020/03" . "email <at> example:a/2/03")
+     ("nndiary+diary:birthdays" . "diary:birthdays")
+     ("nnimap+email <at> example.com:test" . "email <at> example:test")
+     ("nnimap+email <at> example.com:234" . "email <at> example:234")
+
+     ;; This is a very aggressive shortening of the left hand side. I
+     ;; don't like this
+     ("nnimap+email <at> banana.salesman.example.com:234" . "email <at> banana:234")
+     ("nntp+some.where.edu:soc.motss" . "some:s.motss")
+     ("nntp+news.gmane.org:gmane.emacs.gnus.general" . "news:g.e.g.general")
+     ("nntp+news.gnus.org:gmane.text.docbook.apps" . "news:g.t.d.apps")
+
+     ;; I think we should shorten using [[:alnum:]] characters if we
+     ;; can so this would be "I/Bananas" instead of "[/Bananas"
+     ("nnimap+email <at> example.com:[Invoices]/Bananas" . "email <at> example:[/Bananas")
+
+     ;; Both my previous woes in one
+     ("nnimap+email <at> banana.salesman.example.com:[Invoices]/Bananas" . "email <at> banana:[/Bananas")
+
+     ;; What is going on here? Is the "n" from "nnspool" somehow?
+     ("nnspool+alt.binaries.pictures.furniture" . "n.b.p.furniture"))))
 
-(provide 'gnus-tests)
 ;;; gnus-tests.el ends here
-- 
2.33.1

Message #8 received at 51450 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Morgan.J.Smith <at> outlook.com
Cc: 51450 <at> debbugs.gnu.org
Subject: Re: bug#51450: Bugs in gnus-short-group-name
Date: Fri, 29 Oct 2021 15:31:53 +0200

Morgan.J.Smith <at> outlook.com writes:

> diff --git a/test/lisp/gnus/gnus-tests.el b/test/lisp/gnus/gnus-tests.el

Thanks; mostly applied, but moved to gnus-group-tests.el.

> +     ;; This is a very aggressive shortening of the left hand side. I
> +     ;; don't like this
> +     ("nnimap+email <at> banana.salesman.example.com:234" . "email <at> banana:234")
> +     ("nntp+some.where.edu:soc.motss" . "some:s.motss")
> +     ("nntp+news.gmane.org:gmane.emacs.gnus.general" . "news:g.e.g.general")
> +     ("nntp+news.gnus.org:gmane.text.docbook.apps" . "news:g.t.d.apps")

A function like this is very DWIM, and those are what I mean.  :-)

> +     ;; I think we should shorten using [[:alnum:]] characters if we
> +     ;; can so this would be "I/Bananas" instead of "[/Bananas"
> +     ("nnimap+email <at> example.com:[Invoices]/Bananas" . "email <at> example:[/Bananas")

I've now fixed this on the trunk.

> +     ;; What is going on here? Is the "n" from "nnspool" somehow?
> +     ("nnspool+alt.binaries.pictures.furniture" . "n.b.p.furniture"))))

Yes, I think so.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.