GNU bug report logs - #51451
image-transform-original has a misleading name

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51451 <at> debbugs.gnu.org
Subject: bug#51451: image-transform-original has a misleading name
Date: Sun, 31 Oct 2021 21:46:17 +0200

> These are the commands under the "s" key in image-mode:
>
>     s 0             image-transform-reset
>     s b             image-transform-fit-both
>     s f             image-mode-fit-frame
>     s h             image-transform-fit-to-height
>     s m             image-transform-set-smoothing
>     s o             image-transform-original
>     s r             image-transform-set-rotation
>     s s             image-transform-set-scale
>     s w             image-transform-fit-to-width
>
> Perhaps this would be less confusing if these commands were named
> `image-display-*' instead of `image-transform-*'?
>
>     s 0             image-display-reset-size
>     s b             image-display-fit-both
>     s f             image-mode-fit-frame
>     s h             image-display-fit-to-height
>     s m             image-display-set-smoothing
>     s o             image-display-original-size
>     s r             image-display-set-rotation
>     s s             image-display-set-scale
>     s w             image-display-fit-to-width
>
> Doesn't that make more sense?

image-transform-* commands are modifying the values of
image-transform-* variables.
Would you propose to rename variables as well?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.