GNU bug report logs - #51446
[PATCH] image-dired: Unreverse accidentally reversed menus

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 27 Oct 2021 19:37:02 UTC

Severity: normal

Tags: patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51446 <at> debbugs.gnu.org
Subject: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed menus
Date: Thu, 28 Oct 2021 09:57:54 +0300
> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 27 Oct 2021 12:36:05 -0700
> 
>     image-dired: Unreverse accidentally reversed menus
> 
>     * lisp/image-dired.el (image-dired-thumbnail-mode-map)
>     (image-dired-display-image-mode-map, image-dired-minor-mode-map):
>     In commits b905454680c7 and bed0373855ea, the menus were converted to
>     use 'easy-menu-define', but they were reversed in the process.
>     Unreverse the menus.
> 
> Eli and Lars, is the attached bug fix acceptable for 28.1?  This merely
> reverses the menus and does nothing else.  The change as such is a
> mechanical one, and after adjusting one two-line entry really just comes
> down to a `reverse-region', so I think it should be safe.

I don't understand: I seem to see the same order of the menu items in
Emacs 27 and on the current release branch, so what am I missing?




This bug report was last modified 3 years and 204 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.