GNU bug report logs - #51446
[PATCH] image-dired: Unreverse accidentally reversed menus

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51446 in the body.
You can then email your comments to 51446 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] image-dired: Unreverse accidentally reversed menus
Date: Wed, 27 Oct 2021 12:36:05 -0700

[Message part 1 (text/plain, inline)]

    image-dired: Unreverse accidentally reversed menus

    * lisp/image-dired.el (image-dired-thumbnail-mode-map)
    (image-dired-display-image-mode-map, image-dired-minor-mode-map):
    In commits b905454680c7 and bed0373855ea, the menus were converted to
    use 'easy-menu-define', but they were reversed in the process.
    Unreverse the menus.

Eli and Lars, is the attached bug fix acceptable for 28.1?  This merely
reverses the menus and does nothing else.  The change as such is a
mechanical one, and after adjusting one two-line entry really just comes
down to a `reverse-region', so I think it should be safe.

[0001-image-dired-Unreverse-accidentally-reversed-menus.patch (text/x-diff, attachment)]

Message #8 received at 51446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51446 <at> debbugs.gnu.org
Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed
 menus
Date: Thu, 28 Oct 2021 09:57:54 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Wed, 27 Oct 2021 12:36:05 -0700
> 
>     image-dired: Unreverse accidentally reversed menus
> 
>     * lisp/image-dired.el (image-dired-thumbnail-mode-map)
>     (image-dired-display-image-mode-map, image-dired-minor-mode-map):
>     In commits b905454680c7 and bed0373855ea, the menus were converted to
>     use 'easy-menu-define', but they were reversed in the process.
>     Unreverse the menus.
> 
> Eli and Lars, is the attached bug fix acceptable for 28.1?  This merely
> reverses the menus and does nothing else.  The change as such is a
> mechanical one, and after adjusting one two-line entry really just comes
> down to a `reverse-region', so I think it should be safe.

I don't understand: I seem to see the same order of the menu items in
Emacs 27 and on the current release branch, so what am I missing?

Message #11 received at 51446 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51446 <at> debbugs.gnu.org
Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed
 menus
Date: Thu, 28 Oct 2021 00:27:18 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> I don't understand: I seem to see the same order of the menu items in
> Emacs 27 and on the current release branch, so what am I missing?

The regression was introduced in Emacs 26.1, in these commits:

    $ git tag --contain=bed0373855ea | head -3
    emacs-26.0.90
    emacs-26.0.91
    emacs-26.1
    $ git tag --contain=b905454680c7 | head -3
    emacs-26.0.90
    emacs-26.0.91
    emacs-26.1

It's the easy-to-make mistake of converting to easy-menu-define without
realizing that the order is not reversed there.

Message #14 received at 51446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 51446 <at> debbugs.gnu.org
Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed
 menus
Date: Thu, 28 Oct 2021 12:32:37 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Thu, 28 Oct 2021 00:27:18 -0700
> Cc: 51446 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I don't understand: I seem to see the same order of the menu items in
> > Emacs 27 and on the current release branch, so what am I missing?
> 
> The regression was introduced in Emacs 26.1, in these commits:
> 
>     $ git tag --contain=bed0373855ea | head -3
>     emacs-26.0.90
>     emacs-26.0.91
>     emacs-26.1
>     $ git tag --contain=b905454680c7 | head -3
>     emacs-26.0.90
>     emacs-26.0.91
>     emacs-26.1
> 
> It's the easy-to-make mistake of converting to easy-menu-define without
> realizing that the order is not reversed there.

Thanks.  I cannot invoke image-dired-minor-mode in Emacs 25, so I
cannot see the problem.  I don't really understand why the order of
the items in the menu matters in this case.  but it doesn't matter;
please go ahead and install the change.

Message #17 received at 51446 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 51446 <at> debbugs.gnu.org
Subject: Re: bug#51446: [PATCH] image-dired: Unreverse accidentally reversed
 menus
Date: Thu, 28 Oct 2021 07:04:50 -0400

close 51446 28.1
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks.  I cannot invoke image-dired-minor-mode in Emacs 25, so I
> cannot see the problem.  I don't really understand why the order of
> the items in the menu matters in this case.  but it doesn't matter;

I believe it should be enough to just say `M-x image-dired'.

As for why the fix matters, it's mostly just confusing to have
"Quit" at the top.

> please go ahead and install the change.

Thanks, pushed to emacs-28 (commit f52fa1c150).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.