GNU bug report logs - #51355
Fwd: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 51355 in the body.
You can then email your comments to 51355 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sharaf Zaman <shzam <at> sdf.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Fwd: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap
Date: Sat, 23 Oct 2021 15:41:00 +0000

[Message part 1 (text/plain, inline)]

Hello!

I discovered that there's a memory leak in the pgtk code, if the windows are
created/destroyed/moved/shrunk/widened frequently. I've verified it with
profiler that this indeed is the location (https://i.imgur.com/LnrgGyj.png) and
fixed it (https://i.imgur.com/zdgnn5K.png).

PS: This is my first time sending a patch over an email, I'm not 100%
sure if this is how it's done.

--
Kind Regards,
Sharaf Zaman

[0001-Fix-a-memory-leak-in-pgtk_draw_fringe_bitmap.patch (text/x-patch, attachment)]

Message #10 received at 51355 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sharaf Zaman <shzam <at> sdf.org>
Cc: 51355 <at> debbugs.gnu.org, 51354 <at> debbugs.gnu.org,
 Yuuki Harano <masm+github <at> masm11.me>
Subject: Re: bug#51354: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap
Date: Sun, 24 Oct 2021 20:09:17 +0200

Sharaf Zaman <shzam <at> sdf.org> writes:

> I discovered that there's a memory leak in the pgtk code, if the windows are
> created/destroyed/moved/shrunk/widened frequently. I've verified it with
> profiler that this indeed is the location (https://i.imgur.com/LnrgGyj.png) and
> fixed it (https://i.imgur.com/zdgnn5K.png).

Makes sense to me, so I've applied it to the pgtk branch, but perhaps
Yuuki has a comment (added to the CCs).

> PS: This is my first time sending a patch over an email, I'm not 100%
> sure if this is how it's done.

Looked perfect.  :-)

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 51355 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sharaf Zaman <shzam <at> sdf.org>
Cc: 51355 <at> debbugs.gnu.org, 51354 <at> debbugs.gnu.org
Subject: Re: bug#51354: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap
Date: Mon, 25 Oct 2021 15:35:57 +0200

Sharaf Zaman <shzam <at> sdf.org> writes:

>> This change was small enough to apply without assigning copyright to the
>> FSF, but for future patches you want to submit, it might make sense to
>> get the paperwork started now, so that subsequent patches can be applied
>> speedily. Would you be willing to sign such paperwork?
>
> Sure! Where can I do that?

Great!  Here's the form to get started:


Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.