GNU bug report logs - #5132
23.1; Incorrect toolbar icon display with (tool-bar-mode 1)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5132 in the body.
You can then email your comments to 5132 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Steve Revilak <steve <at> srevilak.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; Incorrect toolbar icon display with (tool-bar-mode 1)
Date: Sat, 5 Dec 2009 22:49:26 -0500

[Message part 1 (text/plain, inline)]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs <at> gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Symptoms: when (tool-bar-mode 1) is used with Emacs 23.1.1 on Mac OS
X, the toolbar icons are black and gray silhouettes.  Here is a screen
capture which shows toolbar mode on Emacs 23.

  http://www.cs.umb.edu/~srevilak/images/tool-bar-mode-23.png

I expected to see color tool bar icons, as show in the following image
(a screen capture taken from emacs 22.3.1)

  http://www.cs.umb.edu/~srevilak/images/tool-bar-mode-22.png

Steps to Reproduce:

Start emacs as follows:

  /Applications/Emacs-23.1.app/Contents/MacOS/Emacs --no-init-file

Once emacs has started, eval the following

  (tool-bar-mode 1)

uname for my system is

  Darwin spud.local 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Applications/Emacs-23.1.app/Contents/Resources/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (powerpc-apple-darwin8.11.0, NS apple-appkit-824.48)
 of 2009-10-14 on spud.local
Windowing system distributor `Apple', version 10.3.824
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <return> C-x C-f 
f o o . t x t <return> ( t o o l - b a r - m o d e 
SPC 1 ) C-x C-e s-x <help-echo> C-g C-x C-e <left> 
<backspace> 0 <right> C-x C-e <left> <backspace> 1 
<right> C-x C-e <help-echo> C-a C-k s-x s-x M-x r e 
p o <tab> t <tab> <backspace> r <tab> <return>

Recent messages:
kill-region: The mark is not set now, so there is no region
Quit
Auto-saving...
Quit
t
nil
t
Auto-saving...
kill-region: The mark is not set now, so there is no region [2 times]
Making completion list...

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 5132 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Steve Revilak <steve <at> srevilak.net>
Cc: 5132 <at> debbugs.gnu.org
Subject: Re: 23.1; Incorrect toolbar icon display with (tool-bar-mode 1)
Date: Sun, 06 Dec 2009 14:10:45 -0500

> Symptoms: when (tool-bar-mode 1) is used with Emacs 23.1.1 on Mac OS
> X, the toolbar icons are black and gray silhouettes.  Here is a screen
> capture which shows toolbar mode on Emacs 23.
>
>   http://www.cs.umb.edu/~srevilak/images/tool-bar-mode-23.png
>
> I expected to see color tool bar icons, as show in the following image
> (a screen capture taken from emacs 22.3.1)
>
>   http://www.cs.umb.edu/~srevilak/images/tool-bar-mode-22.png

Did you compile Emacs with image support?  (You need the image
development libraries.  The output of `configure' should tell you
whether they were found.)

Message #15 received at 5132 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Steve Revilak <steve <at> srevilak.net>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 5132 <at> debbugs.gnu.org
Subject: Re: 23.1; Incorrect toolbar icon display with (tool-bar-mode 1)
Date: Sun, 6 Dec 2009 15:25:19 -0500

[Message part 1 (text/plain, inline)]

>From: Chong Yidong <cyd <at> stupidchicken.com>

>Did you compile Emacs with image support?  (You need the image
>development libraries.  The output of `configure' should tell you
>whether they were found.)

Chong,

Thanks for responding to my bug report.  I saved the configure command
line, as well as the summary sectionof configure's output, which I'll
reproduce below.

------------------------------------------------------------------
$ ./configure --with-ns

   [... didn't save this part ...]

Configured for `powerpc-apple-darwin8.11.0'.

  Where should the build process find the source code? /Users/srevilak/Desktop/emacs-23.1
  What operating system and machine description files should Emacs use?
        `s/darwin.h' and `m/macppc.h'
  What compiler should emacs be built with?               gcc -g -O2 -Wno-pointer-sign 
  Should Emacs use the GNU version of malloc?             no
    (The GNU allocators don't work with this system configuration.)
  Should Emacs use a relocating allocator for buffers?    no
  Should Emacs use mmap(2) for buffer allocation?         no
  What window system should Emacs use?                    nextstep
  What toolkit should Emacs use?                          none
  Where do we find X Windows header files?                /usr/X11R6/include
  Where do we find X Windows libraries?                   /usr/X11R6/lib
  Does Emacs use -lXaw3d?                                 no
  Does Emacs use -lXpm?                                   no
  Does Emacs use -ljpeg?                                  no
  Does Emacs use -ltiff?                                  no
  Does Emacs use a gif library?                           no 
  Does Emacs use -lpng?                                   no
  Does Emacs use -lrsvg-2?                                no
  Does Emacs use -lgpm?                                   no
  Does Emacs use -ldbus?                                  no
  Does Emacs use -lfreetype?                              no
  Does Emacs use -lm17n-flt?                              no
  Does Emacs use -lotf?                                   no
  Does Emacs use -lxft?                                   no
  Does Emacs use toolkit scroll bars?                     yes

$ make

$ make install
------------------------------------------------------------------


At the time, I was a surprised by the summary (it appeared that Emacs
would be compiled with png, jpeg support), but I went ahead and did
the compilation anyway.  After compiling, I tried to view a few .png
and .jpg files via

  C-x C-f /path/to/image-file RETURN 

The .png and .jpg images displayed correctly, so I assumed that the
supporting libraries had been found.

After poking around Contents/Resources/etc/images, I see that there
are .xpm images for the toolbar (for example,
Contents/Resources/etc/images/help.xpm).  In Emacs 23I tried to open
help.xpm via C-x C-f, and what I see is exactly the same as the help
icon in the toolbar.


I've tried to recompile emacs 23.1.1, explictly requesting xpm
support.

  $ unset CFLAGS CXXFLAGS LDFLAGS
  $ ./configure --with-ns --with-xpm 2>&1 | tee ~/configure.out

Configure declared

  Does Emacs use -lXpm?                                   no

(I'll attach the full configure output).

After "make", and "make install", I repeated my earlier `steps to
reproduce'; I observed no change in behavior -- the toolbar icons are
still black silhouettes (and .png, .jpg image view correctly when
opened via C-x C-f.).

There are xpm libraries and header files installed on my system

  $ ls -l /usr/X11R6/lib/libXpm.*
  136 -rw-r--r--   1 root  wheel  136144 Nov  6  2006 /usr/X11R6/lib/libXpm.4.11.dylib
    4 lrwxr-xr-x   1 root  wheel      17 Jun 20 20:56 /usr/X11R6/lib/libXpm.4.dylib@ -> libXpm.4.11.dylib
  180 -rw-r--r--   1 root  wheel  183780 Mar 23  2007 /usr/X11R6/lib/libXpm.a
    4 lrwxr-xr-x   1 root  wheel      17 Jun 20 20:56 /usr/X11R6/lib/libXpm.dylib@ -> libXpm.4.11.dylib

  $ ls -l /usr/X11R6/include/X11/xpm.h 
  16 -r--r--r--   1 root  wheel  16286 Mar 23  2007 /usr/X11R6/include/X11/xpm.h


What else can I try?


Steve Revilak

[configure.out (text/plain, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #22 received at 5132 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Steve Revilak <steve <at> srevilak.net>
To: 5132 <at> debbugs.gnu.org
Subject: 23.1; FIXED: Incorrect toolbar icon display with (tool-bar-mode 1)
Date: Mon, 7 Dec 2009 08:46:34 -0500

[Message part 1 (text/plain, inline)]

Bug 5132 appears to be fixed on the trunk.

Last night, I checked out the CVS sources for emacs, according to
instructions posted at http://savannah.gnu.org/cvs/?group=emacs.

This morning, I followed the directions in INSTALL.CVS to compile from
source.  The specific commands I used were

  ./configure --with-ns
  make bootstrap
  make install

According to (emacs-version) the version number of this emacs is
23.1.50.1.

In version 23.1.50.1, the tool bar icons appear correctly -- as color
icons, not black and gray silhouettes.  I will attach a screen shot,
produced by my earlier `Steps to Reproduce'.  This screen shot shows
the correct icon presentation.

Steve

[tool-bar-mode-23.1.50.1.png (image/png, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #25 received at 5132 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Steve Revilak <steve <at> srevilak.net>
Cc: 5132 <at> debbugs.gnu.org
Subject: Re: bug#5132: 23.1; FIXED: Incorrect toolbar icon display with (tool-bar-mode 1)
Date: Mon, 7 Dec 2009 07:19:44 -0800 (PST)

Steve Revilak <steve <at> srevilak.net> writes:

  > Bug 5132 appears to be fixed on the trunk.

In that case you can you please close the bug.

You can do that by sending an email to
5132-done <at> debbugs.gnu.org (i.e. BUGNUMBER-done <at> debbugs.gnu.org).


  > Last night, I checked out the CVS sources for emacs, according to
  > instructions posted at http://savannah.gnu.org/cvs/?group=emacs.
  > 
  > This morning, I followed the directions in INSTALL.CVS to compile from
  > source.  The specific commands I used were
  > 
  >   ./configure --with-ns
  >   make bootstrap
  >   make install
  > 
  > According to (emacs-version) the version number of this emacs is
  > 23.1.50.1.
  > 
  > In version 23.1.50.1, the tool bar icons appear correctly -- as color
  > icons, not black and gray silhouettes.  I will attach a screen shot,
  > produced by my earlier `Steps to Reproduce'.  This screen shot shows
  > the correct icon presentation.
  > 
  > Steve

Message #30 received at 5132-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Steve Revilak <steve <at> srevilak.net>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 5132-done <at> debbugs.gnu.org
Subject: Re: bug#5132: 23.1; FIXED: Incorrect toolbar icon display with
	(tool-bar-mode 1)
Date: Mon, 7 Dec 2009 10:48:32 -0500

[Message part 1 (text/plain, inline)]

>From: Dan Nicolaescu <dann <at> ics.uci.edu>
>Subject: Re: bug#5132: 23.1; FIXED: Incorrect toolbar icon display with (tool-bar-mode 1)

>Steve Revilak <steve <at> srevilak.net> writes:
>
>  > Bug 5132 appears to be fixed on the trunk.
>
>In that case you can you please close the bug.
>
>You can do that by sending an email to
>5132-done <at> emacsbugs.donarmstrong.com (i.e. BUGNUMBER-done <at> emacsbugs.donarmstrong.com).

Dan,

Thanks for the instructions.  I will do that.

Steve

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.