GNU bug report logs - #5119
ruby-mode binds TAB

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5119 in the body.
You can then email your comments to 5119 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: ruby-mode binds TAB
Date: Fri, 4 Dec 2009 04:36:13 +0100

It binds TAB to ruby-indent-line. That is against the rules. ;-)

It should instead leave this unbound and do

  (set (make-local-variable 'indent-line-function)
       'ruby-indent-line)

Index: ruby-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/ruby-mode.el,v
retrieving revision 1.11
diff -c -r1.11 ruby-mode.el
*** ruby-mode.el	26 Oct 2009 06:43:41 -0000	1.11
--- ruby-mode.el	4 Dec 2009 03:35:16 -0000
***************
*** 166,172 ****
      (define-key map (kbd "M-C-n") 'ruby-end-of-block)
      (define-key map (kbd "M-C-h") 'ruby-mark-defun)
      (define-key map (kbd "M-C-q") 'ruby-indent-exp)
-     (define-key map (kbd "TAB")   'ruby-indent-line)
      (define-key map (kbd "C-M-h") 'backward-kill-word)
      (define-key map (kbd "C-j")   'reindent-then-newline-and-indent)
      (define-key map (kbd "C-m")   'newline)
--- 166,171 ----
***************
*** 1390,1395 ****
--- 1389,1396 ----
    (setq major-mode 'ruby-mode)
    (ruby-mode-variables)

+   (set (make-local-variable 'indent-line-function)
+        'ruby-indent-line)
    (set (make-local-variable 'imenu-create-index-function)
         'ruby-imenu-create-index)
    (set (make-local-variable 'add-log-current-defun-function)

Message #12 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 5119 <at> debbugs.gnu.org, Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Re: bug#5119: ruby-mode binds TAB
Date: Mon, 07 Dec 2009 13:32:58 -0500

> It binds TAB to ruby-indent-line. That is against the rules. ;-)
> It should instead leave this unbound and do

>   (set (make-local-variable 'indent-line-function)
>        'ruby-indent-line)

Yes, please,


        Stefan

Message #22 received at 5119 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: 5119 <at> debbugs.gnu.org
Date: Sun, 27 Jun 2010 14:38:25 +0200

This bug was merged with another bug which was originally submitted in
March 30 2009 and no one seems to have any objections.

Could anyone apply the patch?

-- 
Deniz Dogan

Message #25 received at 5119 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Deniz Dogan'" <deniz.a.m.dogan <at> gmail.com>, <5119 <at> debbugs.gnu.org>
Subject: RE: bug#5119: 
Date: Sun, 27 Jun 2010 06:56:32 -0700

> This bug was merged with another bug which was originally submitted in
> March 30 2009 and no one seems to have any objections.
> 
> Could anyone apply the patch?

Please mention the bug it was merged with in your mail, so someone who might be
interested need not go to the bug tracker to look up this info. Thx.

Message #28 received at 5119 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz.a.m.dogan <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 5119 <at> debbugs.gnu.org
Subject: Re: bug#5119:
Date: Sun, 27 Jun 2010 16:06:53 +0200

2010/6/27 Drew Adams <drew.adams <at> oracle.com>:
>> This bug was merged with another bug which was originally submitted in
>> March 30 2009 and no one seems to have any objections.
>>
>> Could anyone apply the patch?
>
> Please mention the bug it was merged with in your mail, so someone who might be
> interested need not go to the bug tracker to look up this info. Thx.
>
>

It was merged with #2820 named "23.0.91; ruby-mode binds keys it
probably shouldn't".

-- 
Deniz Dogan

Message #33 received at 5119-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 5119-done <at> debbugs.gnu.org
Subject: Re: ruby-mode binds TAB
Date: Sun, 27 Jun 2010 14:19:24 -0400

> It binds TAB to ruby-indent-line. That is against the rules. ;-)
>
> It should instead leave this unbound and do
>
>   (set (make-local-variable 'indent-line-function)
>        'ruby-indent-line)

Checked in, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.