GNU bug report logs - #50160
28.0.50; Wrong NSToolbarItem identifier

Previous Next

Package: emacs;

Reported by: tsuucat <tsuucat <at> icloud.com>

Date: Sun, 22 Aug 2021 02:33:01 UTC

Severity: normal

Found in version 28.0.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: tsuucat <tsuucat <at> icloud.com>
To: 50160 <at> debbugs.gnu.org
Subject: bug#50160: 28.0.50; Wrong NSToolbarItem identifier
Date: Sun, 22 Aug 2021 11:32:05 +0900

Emacs version: 28.0.50
window system: ns

EmacsToolbar now uses [img hash] as NSToolbarItem’s identifier
(see addDisplayItemWithImage in src/nsmenu.m).

This is not good because this causes conflict.
For example, “close” icon is used as `kill-this-buffer' by default but
isearch-tool-bar-map uses “close” icon as `isearch-cancel’.
addDisplayItemWithImage reuses NSToolbarItem which has same 
identifier so when in isearch “close” icon on toolbar doesn’t work.

I’m not a Objective-C expert so I don’t know what value should be set
as correct identifier... 🙇

--
tsuucat
This bug report was last modified 2 years and 275 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.