GNU bug report logs - #50159
[PATCH] Set label for NSToolbarItem

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50159 in the body.
You can then email your comments to 50159 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tsuucat <tsuucat <at> icloud.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Set label for NSToolbarItem
Date: Sun, 22 Aug 2021 11:11:58 +0900

[Message part 1 (text/plain, inline)]

Emacs version: 28.0.50
window system: ns

I found when toolbar narrowed and ≫ is clicked there is no text
(no-label.png). This is because ToolbarItem has no label.


I made a patch to set label for NSToolbarItem.

Thanks.

--
tsuucat

[no-label.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

[0001-Set-label-for-NSToolbarItem.patch (application/octet-stream, attachment)]

Message #10 received at 50159-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: tsuucat <tsuucat <at> icloud.com>
Cc: 50159-done <at> debbugs.gnu.org
Subject: Re: bug#50159: [PATCH] Set label for NSToolbarItem
Date: Sun, 22 Aug 2021 20:59:46 +0100

On Sun, Aug 22, 2021 at 11:11:58AM +0900, tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote:
> Emacs version: 28.0.50
> window system: ns
> 
> I found when toolbar narrowed and ≫ is clicked there is no text
> (no-label.png). This is because ToolbarItem has no label.
> 
> 
> I made a patch to set label for NSToolbarItem.

This looks good. I've pushed it to the master branch.

Thanks!

-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.