GNU bug report logs - #5002
htmlfontify should remove some text properties

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#5002: marked as done (htmlfontify should remove some text
 properties)
Date: Wed, 09 Dec 2009 06:05:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 09 Dec 2009 00:57:43 -0500
with message-id <jwv7hswd70x.fsf-monnier+emacsbugreports <at> gnu.org>
and subject line Re: bug#5002: patch
has caused the Emacs bug report #5002,
regarding htmlfontify should remove some text properties
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
5002: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5002
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>, Vivek Dasmohapatra <vivek <at> etla.org>
Subject: htmlfontify should remove some text properties
Date: Sat, 21 Nov 2009 13:05:09 +0100

[Message part 3 (text/plain, inline)]

I just notice when I played a bit with hfyview.el that there is a bug
in hfy-fontify-buffer. Or at least I believe it is there.

The problem seems to be that a substring is copied with all text
properties to the new buffer. Some of them will prevent htmlfontify
from working correctly. I think the call to copy-buffer should be
replaced with something that does the same thing but removes some of
the text properties.

This is what I just did in hfyview.el, but that is the wrong place to
do it. See line 512 in the attached hfyview.el for some suspicious
text properties (I am not sure how they work so I took them all.
Beside that I saw that font-sticky and rear-nonsticky is not described
on (info "(elisp) Special Properties").)

I found the problem when I did like this:

 load hfyview.el
 M-x hfyview-frame-mode
 M-x
 Push <apps>

This will work now, but that is due to that the call to propertize on
line 515 in hfyview.el removes some text properties from the variable
str before the insertion in the buffer. (I am not sure which ones that
helped here.)

If you do not remove these text properties then the content of the
minibuffer will not be shown in the htmlfontify output.

I have attached hfyview.el

[hfyview.el (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Vivek Dasmohapatra <vivek <at> etla.org>
Subject: Re: bug#5002: patch
Date: Wed, 09 Dec 2009 00:57:43 -0500

> This patch should allow those props to be stripped.

> A defcustom has been added and the properties listed in it should be
> ripped out just after the buffer is copied.

Installed,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.