GNU bug report logs -
#5001
erc should use 'font-lock-face, not 'face
Previous Next
Reported by: Lennart Borgman <lennart.borgman <at> gmail.com>
Date: Sat, 21 Nov 2009 12:05:07 UTC
Severity: normal
Tags: fixed
Merged with 8925
Found in version 23.2
Fixed in version 26.1
Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5001 in the body.
You can then email your comments to 5001 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#5001; Package
emacs.
(Sat, 21 Nov 2009 12:05:07 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Lennart Borgman <lennart.borgman <at> gmail.com>:
New bug report received and forwarded. Copy sent to
Emacs Bugs <bug-gnu-emacs <at> gnu.org>.
(Sat, 21 Nov 2009 12:05:08 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):
erc does not use the font-lock machinery for coloring the erc buffers.
If that is good or not I do not know. However there is a problem with
that it currently use the 'face text property. This prevents hi-lock
from working in its buffer which would otherwise be useful.
Therefore please replace 'face with 'font-lock-face everywhere in erc.
(I do not send a patch. I think it is just easier to make the change
which is quite quick to make. I have tested it though.)
bug reassigned from package 'emacs' to 'emacs,erc'.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org.
(Fri, 15 Jan 2010 02:35:02 GMT)
Full text and
rfc822 format available.
Merged 5001 8925.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org.
(Sun, 07 Oct 2012 01:50:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Sun, 27 Dec 2015 22:33:02 GMT)
Full text and
rfc822 format available.
Message #12 received at 5001 <at> debbugs.gnu.org (full text, mbox):
Lennart Borgman <lennart.borgman <at> gmail.com> writes:
> erc does not use the font-lock machinery for coloring the erc buffers.
> If that is good or not I do not know. However there is a problem with
> that it currently use the 'face text property. This prevents hi-lock
> from working in its buffer which would otherwise be useful.
>
> Therefore please replace 'face with 'font-lock-face everywhere in erc.
>
> (I do not send a patch. I think it is just easier to make the change
> which is quite quick to make. I have tested it though.)
Could you send a patch, anyway?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Mon, 28 Dec 2015 02:02:02 GMT)
Full text and
rfc822 format available.
Message #15 received at 5001 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On Sun, Dec 27, 2015 at 11:20 PM, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>
> > erc does not use the font-lock machinery for coloring the erc buffers.
> > If that is good or not I do not know. However there is a problem with
> > that it currently use the 'face text property. This prevents hi-lock
> > from working in its buffer which would otherwise be useful.
> >
> > Therefore please replace 'face with 'font-lock-face everywhere in erc.
> >
> > (I do not send a patch. I think it is just easier to make the change
> > which is quite quick to make. I have tested it though.)
>
> Could you send a patch, anyway?
>
> Sorry, I do not have the sources installed now.
[Message part 2 (text/html, inline)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Thu, 04 Feb 2016 06:57:02 GMT)
Full text and
rfc822 format available.
Message #18 received at 5001 <at> debbugs.gnu.org (full text, mbox):
Lennart Borgman <lennart.borgman <at> gmail.com> writes:
> erc does not use the font-lock machinery for coloring the erc buffers.
> If that is good or not I do not know. However there is a problem with
> that it currently use the 'face text property. This prevents hi-lock
> from working in its buffer which would otherwise be useful.
>
> Therefore please replace 'face with 'font-lock-face everywhere in erc.
>
> (I do not send a patch. I think it is just easier to make the change
> which is quite quick to make. I have tested it though.)
It has been suggested that all instances of "'face" should be replaced
with "'font-lock-face" in erc.
I know nothing about font-locking, so I have no idea whether this is a
good idea or not. Are there anybody on the erc mailing list that has on
opinion here?
-*- mode: grep; default-directory: "~/src/emacs/emacs-25/lisp/erc/" -*-
Grep started at Thu Feb 4 17:53:49
grep --color -nH -e "'face" *.el
erc-button.el:79: :type 'face
erc-button.el:84: :type 'face
erc-button.el:92: :type 'face
erc-button.el:393: (let ((old (erc-list (get-text-property from 'face)))
erc-button.el:395: (end (next-single-property-change from 'face nil to))
erc-button.el:403: (put-text-property pos end 'face new)
erc-button.el:405: old (erc-list (get-text-property pos 'face))
erc-button.el:406: end (next-single-property-change pos 'face nil to)))))
erc-capab.el:194: 'face 'erc-capab-identify-unidentified))))))
erc-dcc.el:1208: 'dcc-chat-privmsg ?n (erc-propertize erc-dcc-from 'face
erc-goodies.el:478: 'face
erc-list.el:75: 'face 'fixed-pitch)
erc-list.el:79: 'face 'fixed-pitch)
erc-list.el:157: 'face 'fixed-pitch)
erc-match.el:489: 'face match-face (current-buffer)))
erc-match.el:498: 'face match-face (current-buffer))
erc-match.el:503: 'face match-face))))
erc-match.el:508: 'face match-face (current-buffer)))
erc-match.el:524: 'face face))))
erc-match.el:533: 'face match-face)))
erc-stamp.el:350: (erc-put-text-property 0 (length ts) 'face 'erc-timestamp-face ts)
erc-track.el:812: (put-text-property 0 (length name) 'face faces name))
erc-track.el:890: (let ((choice (catch 'face
erc-track.el:893: (throw 'face candidate)))))
erc-track.el:895: (catch 'face
erc-track.el:898: (throw 'face candidate)))))))
erc-track.el:974: (faces (let ((face1 (get-text-property 0 'face str)))
erc-track.el:977: (while (and (setq i (next-single-property-change i 'face str m))
erc-track.el:979: (and (setq cur (get-text-property i 'face str))
erc-track.el:987: 'face '(bold erc-current-nick-face)
erc.el:2273: 'face 'erc-input-face)))))
erc.el:2463: 'face (or (intern-soft
erc.el:3892: 'face (or face 'erc-prompt-face)
erc.el:4262: (erc-put-text-property 0 (length mark-s) 'face msg-face str)
erc.el:4264: 'face nick-face str)
erc.el:4266: 'face msg-face str)
erc.el:4303: 'face 'erc-nick-prefix-face)
erc.el:4314: (erc-propertize open 'face 'erc-default-face)
erc.el:4315: (erc-propertize mode 'face 'erc-my-nick-prefix-face)
erc.el:4316: (erc-propertize nick 'face 'erc-my-nick-face)
erc.el:4317: (erc-propertize close 'face 'erc-default-face)))
erc.el:4319: (erc-propertize prefix 'face 'erc-default-face))))
erc.el:5240: 'face 'erc-notice-face s)
erc.el:5243: (erc-put-text-property 0 (length s) 'face 'erc-notice-face s)
erc.el:5255: (erc-put-text-property 0 (length s) 'face 'erc-error-face s)
erc.el:5445: 'face 'erc-command-indicator-face)
erc.el:5465: 'face 'erc-input-face))
erc.el:5889: 'face 'erc-command-indicator-face sp)
erc.el:5899: 'face 'erc-input-face line)
erc.el:6381: 'face face)
erc.el:6385: (erc-propertize header 'face face)
Grep finished (matches found) at Thu Feb 4 17:53:49
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Thu, 04 Feb 2016 16:48:02 GMT)
Full text and
rfc822 format available.
Message #21 received at 5001 <at> debbugs.gnu.org (full text, mbox):
> I know nothing about font-locking, so I have no idea whether this is a
> good idea or not. Are there anybody on the erc mailing list that has on
> opinion here?
A bit of preliminary testing (not in erc proper) does not show up any
problems. You don't want a total replacement: some of the grepped out
entries are defcustom types, which should still be 'face (as that's
not a property being applied, it's type info for the defcustom mechanism).
I've modified my erc instance appropriately, I'll let it run for a couple of
days and get back to you.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Fri, 05 Feb 2016 01:34:01 GMT)
Full text and
rfc822 format available.
Message #24 received at 5001 <at> debbugs.gnu.org (full text, mbox):
Vivek Dasmohapatra <vivek <at> etla.org> writes:
> I've modified my erc instance appropriately, I'll let it run for a
> couple of days and get back to you.
Great; thanks.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Fri, 05 Feb 2016 02:40:01 GMT)
Full text and
rfc822 format available.
Message #27 received at 5001 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Vivek Dasmohapatra <vivek <at> etla.org> writes:
>
>> I've modified my erc instance appropriately, I'll let it run for a
>> couple of days and get back to you.
>
> Great; thanks.
And can you send a patch for the changes you ended up running with? As
you said, not all of those 'face things should be replaced...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#5001; Package
emacs.
(Sun, 06 Mar 2016 18:04:01 GMT)
Full text and
rfc822 format available.
Message #30 received at 5001 <at> debbugs.gnu.org (full text, mbox):
> And can you send a patch for the changes you ended up running with? As
> you said, not all of those 'face things should be replaced...
Sure... sorry, got sidetracked for a while. Should have a patch for you in a
couple of days.
Added tag(s) fixed.
Request was from
Lars Magne Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Thu, 07 Apr 2016 12:26:01 GMT)
Full text and
rfc822 format available.
bug marked as fixed in version 25.2, send any further explanations to
5001 <at> debbugs.gnu.org and Lennart Borgman <lennart.borgman <at> gmail.com>
Request was from
Lars Magne Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org.
(Thu, 07 Apr 2016 12:26:01 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Fri, 06 May 2016 11:24:04 GMT)
Full text and
rfc822 format available.
bug unarchived.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org.
(Sun, 04 Dec 2016 02:50:02 GMT)
Full text and
rfc822 format available.
bug Marked as fixed in versions 26.1.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org.
(Sun, 04 Dec 2016 02:50:02 GMT)
Full text and
rfc822 format available.
bug No longer marked as fixed in versions 25.2.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org.
(Sun, 04 Dec 2016 02:50:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sun, 01 Jan 2017 12:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 8 years and 170 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.