GNU bug report logs - #50017
[PATCH] gnu: re2c: Update to 2.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50017 in the body.
You can then email your comments to 50017 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergei Trofimovich <slyich <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Sergei Trofimovich <slyich <at> gmail.com>
Subject: [PATCH] gnu: re2c: Update to 2.2.
Date: Thu, 12 Aug 2021 00:35:25 +0100

2.2 version started using python as a test driver. Added it as a
dependency to native inputs.

	* gnu/packages/re2c.scm (re2c): Update to 2.2. Added python as a
	native input dependency.

Signed-off-by: Sergei Trofimovich <slyich <at> gmail.com>
---
 gnu/packages/re2c.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
index e13d15e97a..9bed166e56 100644
--- a/gnu/packages/re2c.scm
+++ b/gnu/packages/re2c.scm
@@ -1,4 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2021 Sergei Trofimovich <slyich <at> gmail.com>
 ;;; Copyright © 2017, 2020 Sergei Trofimovich <slyfox <at> inbox.ru>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;;
@@ -20,13 +21,14 @@
 (define-module (gnu packages re2c)
   #:use-module (guix licenses)
   #:use-module (guix packages)
+  #:use-module (gnu packages python)
   #:use-module (guix download)
   #:use-module (guix build-system gnu))
 
 (define-public re2c
   (package
     (name "re2c")
-    (version "2.1.1")
+    (version "2.2")
     (source (origin
              (method url-fetch)
              (uri (string-append "https://github.com/skvadrik/" name
@@ -34,9 +36,11 @@
                                  name "-" version ".tar.xz"))
              (sha256
               (base32
-               "1y0iwxpkdmw5fcqacs209ix49aasfy88hqmx3qa26m7xz9jf4vh3"))))
+               "1nkbv3bxz1kwwql1pdlnj3lxy5h2vsaif393ivb5b9d8610mxi0g"))))
     (build-system gnu-build-system)
     (home-page "https://re2c.org/")
+    (native-inputs
+       `(("python" ,python)))
     (synopsis "Lexer generator for C/C++")
     (description
      "@code{re2c} generates minimalistic hard-coded state machine (as opposed
-- 
2.32.0

Message #10 received at 50017-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Sergei Trofimovich <slyich <at> gmail.com>
Cc: 50017-done <at> debbugs.gnu.org
Subject: Re: [bug#50017] [PATCH] gnu: re2c: Update to 2.2.
Date: Fri, 13 Aug 2021 23:02:11 +0530

[Message part 1 (text/plain, inline)]

Hi Sergei,

Thanks for the patch! I have applied it on master after a few minor
changes.

> 2.2 version started using python as a test driver. Added it as a
> dependency to native inputs.
>
> 	* gnu/packages/re2c.scm (re2c): Update to 2.2. Added python as a
> 	native input dependency.
>
> Signed-off-by: Sergei Trofimovich <slyich <at> gmail.com>

I simplified the commit message and moved the comment about python for
the test driver to the package definition itself. That way, it will be
more visible to someone reading the package definition.

>  ;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2021 Sergei Trofimovich <slyich <at> gmail.com>
>  ;;; Copyright © 2017, 2020 Sergei Trofimovich <slyfox <at> inbox.ru>

You have specified a new email ID <slyich <at> gmail.com>. If you will not be
using the <slyfox <at> inbox.ru> email ID, I do encourage you to submit a
patch updating occurrences of your older email ID.

Thanks again! :-)

Regards,
Arun

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.