GNU bug report logs - #50016
[PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 50016 in the body.
You can then email your comments to 50016 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency graph.
Date: Wed, 11 Aug 2021 18:11:46 -0400

This changes affects two leaf packages: gqrx and gr-satellites.

I tested that gqrx still works. I'm not sure how to use gr-satellites.

* gnu/packages/radio.scm (gnuradio)[inputs]: Replace python-pyqt with
python-pyqt-without-qtwebkit.
---
 gnu/packages/radio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index b0c5d960ed..4ca0bf65a7 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -531,7 +531,7 @@ used by RDS Spy, and audio files containing @dfn{multiplex} signals (MPX).")
        ("python-numpy" ,python-numpy)
        ("python-pycairo" ,python-pycairo)
        ("python-pygobject" ,python-pygobject)
-       ("python-pyqt" ,python-pyqt)
+       ("python-pyqt" ,python-pyqt-without-qtwebkit)
        ("python-pyyaml" ,python-pyyaml)
        ("qtbase" ,qtbase-5)
        ("qwt" ,qwt)
-- 
2.32.0

Message #8 received at 50016 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 50016 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: gnuradio: Don't include QtWebKit in the dependency
 graph.
Date: Wed, 11 Aug 2021 18:17:34 -0400

I am proposing this change because:

1) QtWebKit is hard to keep building:

<https://bugs.gnu.org/50014>

2) QtWebKit is not really "ready" to be used, being an alpha release
with a huge caveat from upstream:

"WARNING: This release is based on old WebKit revision with known
unpatched vulnerabilities. Please use it carefully and avoid visiting
untrusted websites and using it for transmission of sensitive data.
Please wait for new release from qtwebkit-dev branch to use it with
untrusted content."
https://github.com/qtwebkit/qtwebkit/releases/tag/qtwebkit-5.212.0-alpha4
https://seclists.org/oss-sec/2021/q3/66

3) It doesn't seem to be used by gnuradio, although I'm not 100% sure.
It's not mentioned in the gnuradio build log, anyways.

Message #11 received at 50016 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 50016 <at> debbugs.gnu.org
Subject: Re: [bug#50016] [PATCH] gnu: gnuradio: Don't include QtWebKit in
 the dependency graph.
Date: Thu, 12 Aug 2021 07:29:28 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> skribis:

> I am proposing this change because:
>
> 1) QtWebKit is hard to keep building:
>
> <https://bugs.gnu.org/50014>
>
> 2) QtWebKit is not really "ready" to be used, being an alpha release
> with a huge caveat from upstream:
>
> "WARNING: This release is based on old WebKit revision with known
> unpatched vulnerabilities. Please use it carefully and avoid visiting
> untrusted websites and using it for transmission of sensitive data.
> Please wait for new release from qtwebkit-dev branch to use it with
> untrusted content."
> https://github.com/qtwebkit/qtwebkit/releases/tag/qtwebkit-5.212.0-alpha4
> https://seclists.org/oss-sec/2021/q3/66
>
> 3) It doesn't seem to be used by gnuradio, although I'm not 100% sure.
> It's not mentioned in the gnuradio build log, anyways.

gr-satellites has some functions using HTTP connections, but it's using
python-requests for that, not qtwebkit.
So it looks like nothing based on gnuradio actually depends on qtwebkit,
and your patch will not cause any issue.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 50016-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 50016-done <at> debbugs.gnu.org
Subject: Re: [bug#50016] [PATCH] gnu: gnuradio: Don't include QtWebKit in the
 dependency graph.
Date: Sun, 15 Aug 2021 14:04:45 -0400

On Thu, Aug 12, 2021 at 07:29:28AM +0000, Guillaume Le Vaillant wrote:
> gr-satellites has some functions using HTTP connections, but it's using
> python-requests for that, not qtwebkit.
> So it looks like nothing based on gnuradio actually depends on qtwebkit,
> and your patch will not cause any issue.

Thanks for the advice. I've gone ahead and pushed as
6ebba295038a84bdeb84adf7652c9a4409ca3d90

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.