GNU bug report logs - #4992
Invalid use of strcpy() in etags

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Jan Djärv <jan.h.d <at> swipnet.se>
Subject: bug#4992: marked as done (Invalid use of strcpy() in etags)
Date: Mon, 23 Nov 2009 10:00:08 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 23 Nov 2009 10:51:42 +0100
with message-id <4B0A5B2E.8050305 <at> swipnet.se>
and subject line Re: bug#4992: Invalid use of strcpy() in etags
has caused the Emacs bug report #4992,
regarding Invalid use of strcpy() in etags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
4992: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4992
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tobias Ringström <tobias <at> ringis.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Invalid use of strcpy() in etags
Date: Fri, 20 Nov 2009 16:43:05 +0100

[Message part 3 (text/plain, inline)]

The function absolute_filename() lib-src/etags.c has two invalid calls 
to strcpy() with overlapping arguments. It's undefined C that often 
happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 
2.11 on x86_64, which is default for Fedora 12.

The attached patch replaces the bogus strcpy() calls with calls to 
memmove().

/Tobias

[emacs-23.1-strcpy-bug.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Tobias Ringström <tobias <at> ringis.se>,
        4992 <at> debbugs.gnu.org
Cc: bug-gnu-emacs <at> gnu.org, 4992-done <at> debbugs.gnu.org
Subject: Re: bug#4992: Invalid use of strcpy() in etags
Date: Mon, 23 Nov 2009 10:51:42 +0100

Tobias Ringström skrev:
> The function absolute_filename() lib-src/etags.c has two invalid calls 
> to strcpy() with overlapping arguments. It's undefined C that often 
> happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 
> 2.11 on x86_64, which is default for Fedora 12.
> 
> The attached patch replaces the bogus strcpy() calls with calls to 
> memmove().
> 

Checked in, thanks.

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.