GNU bug report logs - #4992
Invalid use of strcpy() in etags

Previous Next

Package: emacs;

Reported by: Tobias Ringström <tobias <at> ringis.se>

Date: Fri, 20 Nov 2009 15:50:04 UTC

Severity: normal

Done: Jan Djärv <jan.h.d <at> swipnet.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4992 in the body.
You can then email your comments to 4992 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4992; Package emacs. (Fri, 20 Nov 2009 15:50:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to Tobias Ringström <tobias <at> ringis.se>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Fri, 20 Nov 2009 15:50:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Tobias Ringström <tobias <at> ringis.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Invalid use of strcpy() in etags
Date: Fri, 20 Nov 2009 16:43:05 +0100

[Message part 1 (text/plain, inline)]
The function absolute_filename() lib-src/etags.c has two invalid calls 
to strcpy() with overlapping arguments. It's undefined C that often 
happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 
2.11 on x86_64, which is default for Fedora 12.

The attached patch replaces the bogus strcpy() calls with calls to 
memmove().

/Tobias


[emacs-23.1-strcpy-bug.patch (text/plain, attachment)]
bug reassigned from package 'emacs' to 'emacs,etags'. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Sat, 21 Nov 2009 00:55:07 GMT) Full text and rfc822 format available.
Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>, owner <at> emacsbugs.donarmstrong.com:
bug#4992; Package emacs,etags. (Mon, 23 Nov 2009 10:00:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jan Djärv <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>, owner <at> emacsbugs.donarmstrong.com. (Mon, 23 Nov 2009 10:00:04 GMT) Full text and rfc822 format available.

Message #12 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Tobias Ringström <tobias <at> ringis.se>,
        4992 <at> debbugs.gnu.org
Cc: bug-gnu-emacs <at> gnu.org, 4992-done <at> debbugs.gnu.org
Subject: Re: bug#4992: Invalid use of strcpy() in etags
Date: Mon, 23 Nov 2009 10:51:42 +0100

Tobias Ringström skrev:
> The function absolute_filename() lib-src/etags.c has two invalid calls 
> to strcpy() with overlapping arguments. It's undefined C that often 
> happens to work, but breaks very badly for at least gcc 4.4.2 and glibc 
> 2.11 on x86_64, which is default for Fedora 12.
> 
> The attached patch replaces the bogus strcpy() calls with calls to 
> memmove().
> 

Checked in, thanks.

	Jan D.
Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>, owner <at> emacsbugs.donarmstrong.com:
bug#4992; Package emacs,etags. (Mon, 23 Nov 2009 10:00:06 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jan Djärv <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>, owner <at> emacsbugs.donarmstrong.com. (Mon, 23 Nov 2009 10:00:06 GMT) Full text and rfc822 format available.
Reply sent to Jan Djärv <jan.h.d <at> swipnet.se>:
You have taken responsibility. (Mon, 23 Nov 2009 10:00:08 GMT) Full text and rfc822 format available.
Notification sent to Tobias Ringström <tobias <at> ringis.se>:
bug acknowledged by developer. (Mon, 23 Nov 2009 10:00:08 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <bug-gnu-emacs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 21 Dec 2009 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 185 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.