GNU bug report logs - #49917
[PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.

Previous Next

Package: guix-patches;

Reported by: Sarah Morgensen <iskarian <at> mgsn.dev>

Date: Fri, 6 Aug 2021 21:41:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: 49917 <at> debbugs.gnu.org
Subject: [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.
Date: Fri,  6 Aug 2021 14:40:17 -0700
With GCC 9+, go-1.14 fails a test when the gold linker is not
available (https://github.com/golang/go/issues/39157). Backport the fix
for that from https://github.com/golang/go/commit/4ec4a79.

gnu/packages/golang.scm (go-1.14)[arguments]<#:phases>{prebuild}:
Fix test failure with GCC 9+.
---
Hello Guix,

This fixes the CI failure at

  https://ci.guix.gnu.org/build/725502/details

and probably for other platforms as well. This should also probably go to
core-updates.

--
Sarah

 gnu/packages/golang.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d3ef39a2e6..cbcd9adb4c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1247,6 +1247,11 @@ in the style of communicating sequential processes (@dfn{CSP}).")
                    (("/bin/pwd") (which "pwd"))
                    (("/bin/sh") (which "sh")))
 
+                 ;; Backport fix for go-1.14 with GCC 9+
+                 ;; https://github.com/golang/go/issues/39157
+                 (substitute* "cmd/go/note_test.go"
+                   (("cannot find 'ld'") "cannot find [‘']ld[’']"))
+
                  ;; Add libgcc to runpath
                  (substitute* "cmd/link/internal/ld/lib.go"
                    (("!rpath.set") "true"))

base-commit: b2a5a180cfa56e55bc8078d606a971e34e326967
-- 
2.31.1





This bug report was last modified 3 years and 289 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.