GNU bug report logs - #49917
[PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49917 in the body.
You can then email your comments to 49917 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC
 9+.
Date: Fri,  6 Aug 2021 14:40:17 -0700

With GCC 9+, go-1.14 fails a test when the gold linker is not
available (https://github.com/golang/go/issues/39157). Backport the fix
for that from https://github.com/golang/go/commit/4ec4a79.

gnu/packages/golang.scm (go-1.14)[arguments]<#:phases>{prebuild}:
Fix test failure with GCC 9+.
---
Hello Guix,

This fixes the CI failure at

  https://ci.guix.gnu.org/build/725502/details

and probably for other platforms as well. This should also probably go to
core-updates.

--
Sarah

 gnu/packages/golang.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d3ef39a2e6..cbcd9adb4c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1247,6 +1247,11 @@ in the style of communicating sequential processes (@dfn{CSP}).")
                    (("/bin/pwd") (which "pwd"))
                    (("/bin/sh") (which "sh")))
 
+                 ;; Backport fix for go-1.14 with GCC 9+
+                 ;; https://github.com/golang/go/issues/39157
+                 (substitute* "cmd/go/note_test.go"
+                   (("cannot find 'ld'") "cannot find [‘']ld[’']"))
+
                  ;; Add libgcc to runpath
                  (substitute* "cmd/link/internal/ld/lib.go"
                    (("!rpath.set") "true"))

base-commit: b2a5a180cfa56e55bc8078d606a971e34e326967
-- 
2.31.1

Message #10 received at 49917-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: 49917-done <at> debbugs.gnu.org
Subject: Re: [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test
 failure with GCC 9+.
Date: Sun, 8 Aug 2021 15:14:40 +0300

[Message part 1 (text/plain, inline)]

Thanks. Patch pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.