GNU bug report logs - #49365
[PATCH] services: gpm: Use "make-forkexec-contstructor".

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brice Waegeneire <brice <at> waegenei.re>
Subject: bug#49365: closed (Re: bug#49365: [PATCH] services: gpm: Use
 "make-forkexec-contstructor".)
Date: Tue, 13 Jul 2021 05:29:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#49365: [PATCH] services: gpm: Use "make-forkexec-contstructor".

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 49365 <at> debbugs.gnu.org.

-- 
49365: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49365
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 49365-done <at> debbugs.gnu.org
Subject: Re: bug#49365: [PATCH] services: gpm: Use
 "make-forkexec-contstructor".
Date: Tue, 13 Jul 2021 07:28:21 +0200

Mathieu Othacehe <othacehe <at> gnu.org> writes:

>> * gnu/services/base.scm (gpm-shepherd-service)[start]: Replace custom
>> logic with "make-forkexec-constructor".

Thank you for the review, pushed as
1beeef62614dc61876558bcd70af11e2bd6854d6.

[Message part 3 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: gpm: Use "make-forkexec-contstructor".
Date: Sat,  3 Jul 2021 22:40:28 +0200

* gnu/services/base.scm (gpm-shepherd-service)[start]: Replace custom
logic with "make-forkexec-constructor".
---
 gnu/services/base.scm | 24 +++++++-----------------
 1 file changed, 7 insertions(+), 17 deletions(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 6922d7f90b..ab3e441a7b 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -2217,23 +2217,13 @@ instance."
      (list (shepherd-service
             (requirement '(udev))
             (provision '(gpm))
-            (start #~(lambda ()
-                       ;; 'gpm' runs in the background and sets a PID file.
-                       ;; Note that it requires running as "root".
-                       (false-if-exception (delete-file "/var/run/gpm.pid"))
-                       (fork+exec-command (list #$(file-append gpm "/sbin/gpm")
-                                                #$@options))
-
-                       ;; Wait for the PID file to appear; declare failure if
-                       ;; it doesn't show up.
-                       (let loop ((i 3))
-                         (or (file-exists? "/var/run/gpm.pid")
-                             (if (zero? i)
-                                 #f
-                                 (begin
-                                   (sleep 1)
-                                   (loop (1- i))))))))
-
+            ;; 'gpm' runs in the background and sets a PID file.
+            ;; Note that it requires running as "root".
+            (start #~(make-forkexec-constructor
+                      (list #$(file-append gpm "/sbin/gpm")
+                            #$@options)
+                      #:pid-file "/var/run/gpm.pid"
+                      #:pid-file-timeout 3))
             (stop #~(lambda (_)
                       ;; Return #f if successfully stopped.
                       (not (zero? (system* #$(file-append gpm "/sbin/gpm")
-- 
2.31.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.