GNU bug report logs - #49364
[PATCH 0/2] Use log file for tor and ntp services

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49364 in the body.
You can then email your comments to 49364 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Use log file for tor and ntp services
Date: Sat,  3 Jul 2021 22:35:25 +0200

Brice Waegeneire (2):
  services: tor: Log to file.
  services: ntp: Log to file.

 gnu/services/networking.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.31.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] services: tor: Log to file.
Date: Sat,  3 Jul 2021 22:37:54 +0200

* gnu/services/networking.scm (tor-shepherd-service)[start]: Specify log
file.
---
 gnu/services/networking.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 1ae58041d3..0be4a21e7a 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -960,6 +960,7 @@ HiddenServicePort ~a ~a~%"
                 (start #~(make-forkexec-constructor/container
                           (list #$(file-append tor "/bin/tor") "-f" #$torrc)
 
+                          #:log-file "/var/log/tor.log"
                           #:mappings (list (file-system-mapping
                                             (source "/var/lib/tor")
                                             (target source)
-- 
2.31.1

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH 2/2] services: ntp: Log to file.
Date: Sat,  3 Jul 2021 22:37:58 +0200

* gnu/services/networking.scm (ntp-shepherd-service)[start]: Specify log
file.
---
 gnu/services/networking.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 0be4a21e7a..eeb1487116 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -492,7 +492,8 @@ restrict source notrap nomodify noquery\n"))
                                 "-c" #$ntpd.conf "-u" "ntpd"
                                 #$@(if allow-large-adjustment?
                                        '("-g")
-                                       '()))))
+                                       '()))
+                          #:log-file "/var/log/ntpd.log"))
                 (stop #~(make-kill-destructor)))))))))
 
 (define %ntp-accounts
-- 
2.31.1

Message #14 received at 49364 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 49364 <at> debbugs.gnu.org
Subject: Re: bug#49364: [PATCH 0/2] Use log file for tor and ntp services
Date: Wed, 07 Jul 2021 16:39:58 +0200

Hey,

> Brice Waegeneire (2):
>   services: tor: Log to file.
>   services: ntp: Log to file.

It could be nice to add those log files to the ntp-configuration and the
tor-configuration records as users may want to have control on logging.

In the meantime, I guess you can proceed with this first implementation.

Thanks,

Mathieu

Message #19 received at 49364-done <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 49364-done <at> debbugs.gnu.org
Subject: Re: bug#49364: [PATCH 0/2] Use log file for tor and ntp services
Date: Tue, 13 Jul 2021 07:35:27 +0200

Mathieu Othacehe <othacehe <at> gnu.org> writes:

>> Brice Waegeneire (2):
>>   services: tor: Log to file.
>>   services: ntp: Log to file.
>
> It could be nice to add those log files to the ntp-configuration and the
> tor-configuration records as users may want to have control on logging.

ATM I don't have use for specifying the log file path, I can review such
patch when someone write it.  I wrote this one mainly to avoid thoses two
services to write to tty1.

> In the meantime, I guess you can proceed with this first implementation.

Pushed asa5fa05dfc7e5bbe0191938b7824ec264aa842306 and
8bb45504dd9eb441d447e3f1dca174f0231c67d8.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.