GNU bug report logs - #4928
23.1; lm-keywords more flexibility

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Kevin Ryde <user42 <at> zip.com.au>
Subject: bug#4928 closed by Kevin Ryde <user42 <at> zip.com.au> (Re: bug#4928:
 23.1; lm-keywords more flexibility)
Date: Tue, 17 Nov 2009 00:30:06 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#4928: 23.1; lm-keywords more flexibility

It has been closed by Kevin Ryde <user42 <at> zip.com.au>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Kevin Ryde <user42 <at> zip.com.au> by
replying to this email.


-- 
4928: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4928
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kevin Ryde <user42 <at> zip.com.au>
To: 4928-done <at> debbugs.gnu.org
Subject: Re: bug#4928: 23.1; lm-keywords more flexibility
Date: Tue, 17 Nov 2009 11:21:40 +1100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
> Feel free to install it,

Done.

[Message part 3 (message/rfc822, inline)]

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; lm-keywords more flexibility
Date: Sun, 15 Nov 2009 11:30:13 +1100

[Message part 4 (text/plain, inline)]

This is a idea to relax/extend lm-keywords to cope with multi-line
keywords, like say Drew's icicles.el,

  ;; Keywords: internal, extensions, help, abbrev, local, minibuffer,
  ;;           keys, apropos, completion, matching, regexp, command

And comma-only separators like say zenirc-color.el,

  ;; Keywords: zenirc,extensions

And trailing-space as in say vm-summary-faces.el, which had been ok in
Emacs 21.

  ;; Keywords:    VM 


2009-11-13  Kevin Ryde  <user42 <at> zip.com.au>

	* emacs-lisp/lisp-mnt.el (lm-keywords): Allow multi-line keywords.
	(lm-keywords-list): Allow comma-only separator like "foo,bar".
	Ignore trailing spaces by omit-nulls to split-string (fixing
	regression from Emacs 21 due to the incompatible split-string
	change.)

[lisp-mnt.el.keywords.diff (text/x-diff, inline)]

--- lisp-mnt.el.~1.63.~	2009-10-08 11:00:31.000000000 +1100
+++ lisp-mnt.el	2009-11-15 11:27:05.000000000 +1100
@@ -445,16 +445,20 @@
 	    (match-string-no-properties 1)))))))
 
 (defun lm-keywords (&optional file)
-  "Return the keywords given in file FILE, or current buffer if FILE is nil."
+  "Return the keywords given in file FILE, or current buffer if FILE is nil.
+The return value is a `downcase'-ed string, or nil if no keywords
+header.  Multi-line keywords are joined up with a space between
+each line."
   (lm-with-file file
-    (let ((keywords (lm-header "keywords")))
-      (and keywords (downcase keywords)))))
+    (let ((keywords (lm-header-multiline "keywords")))
+      (and keywords
+	   (mapconcat 'downcase keywords " ")))))
 
 (defun lm-keywords-list (&optional file)
   "Return list of keywords given in file FILE."
   (let ((keywords (lm-keywords file)))
     (if keywords
-	(split-string keywords ",?[ \t]"))))
+	(split-string keywords "[, \t\n]+" t))))
 
 (defvar finder-known-keywords)
 (defun lm-keywords-finder-p (&optional file)

[Message part 6 (text/plain, inline)]

In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.