GNU bug report logs - #4927
23.1; checkdoc-proper-noun-regexp with regexp-opt

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4927 in the body.
You can then email your comments to 4927 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; checkdoc-proper-noun-regexp with regexp-opt
Date: Sun, 15 Nov 2009 08:44:28 +1100

[Message part 1 (text/plain, inline)]

This is the simplification I mentioned before for the way
checkdoc-proper-noun-regexp is built.

You'd be tempted to build the regexp within
checkdoc-proper-noun-region-engine (maybe just with mapconcat) for
easier customizing of checkdoc-proper-noun-list, but I suppose nobody
changes it.

2009-11-13  Kevin Ryde  <user42 <at> zip.com.au>

	* emacs-lisp/checkdoc.el (checkdoc-proper-noun-regexp): Build
	value with regexp-opt instead of explicit joining loop.

[checkdoc.el.regexp-opt.diff (text/x-diff, inline)]

--- checkdoc.el.~1.80.~	2009-11-09 08:46:10.000000000 +1100
+++ checkdoc.el	2009-11-09 09:33:33.000000000 +1100
@@ -334,12 +334,9 @@
   ;; "[.!?]" is for noun at end of a sentence, since those chars
   ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
   ;; The \" allows it to be the last sentence in a docstring too.
-  (let ((expr "\\_<\\(")
-	(l checkdoc-proper-noun-list))
-    (while l
-      (setq expr (concat expr (car l) (if (cdr l) "\\|" ""))
-	    l (cdr l)))
-    (concat expr "\\)\\(\\_>\\|[.!?][ \t\n\"]\\)"))
+  (concat "\\_<"
+	  (regexp-opt checkdoc-proper-noun-list t)
+	  "\\(\\_>\\|[.!?][ \t\n\"]\\)")
   "Regular expression derived from `checkdoc-proper-noun-regexp'.")
 
 (defvar checkdoc-common-verbs-regexp nil

[Message part 3 (text/plain, inline)]

In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Message #10 received at 4927 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 4927 <at> debbugs.gnu.org
Subject: Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt
Date: Mon, 16 Nov 2009 23:42:09 -0500

Kevin Ryde wrote:

> This is the simplification I mentioned before for the way
> checkdoc-proper-noun-regexp is built.

I think you should feel free to just install this kind of thing,
without needing to create a bug report.

Message #15 received at 4927-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: 4927-done <at> debbugs.gnu.org
Subject: Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt
Date: Wed, 25 Nov 2009 10:13:43 +1100

Glenn Morris <rgm <at> gnu.org> writes:
>
> I think you should feel free to just install this kind of thing,
> without needing to create a bug report.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.