GNU bug report logs - #49184
[PATCH]: Strings in (guix diagnostics) are not translated

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49184 in the body.
You can then email your comments to 49184 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH]: Strings in (guix diagnostics) are not translated
Date: Wed, 23 Jun 2021 12:25:27 +0200

[Message part 1 (text/plain, inline)]

Hi Guix,

(guix diagnostics) has some translatable strings.
See e.g. the following code:

(define-diagnostic warning (G_ "warning: ") %warning-color) ;emit a warning
(define-diagnostic info (G_ "") %info-color)
(define-diagnostic report-error (G_ "error: ") %error-color)

These are currently not translated and don't appear on translate.fedoraproject.org.
The issue appears to be that guix/diagnostics.scm does not appear in
guix/POTFILES.in.

A patch that should fix this is attached.

Greetings,
Maxime.

[0001-po-Add-guix-diagnostics-to-the-list-of-files-with-I1.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 49184 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: 49184 <at> debbugs.gnu.org
Cc: maximedevos <at> telenet.be
Subject: [PATCH]: Strings in (guix diagnostics) are not translated
Date: Wed, 23 Jun 2021 16:22:27 +0200

Before adding guix/diagnostics.scm to the POTFILES, you should probably
drop the call (G_ "").  Last time I checked, that did not actually
return the empty string, but some metadata.

(I actually sent a similar reply through the web interface, but it was
apparently swallowed somewhere)

Message #13 received at 49184-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49184-done <at> debbugs.gnu.org
Subject: Re: bug#49184: [PATCH]: Strings in (guix diagnostics) are not
 translated
Date: Wed, 23 Jun 2021 23:04:55 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> These are currently not translated and don't appear on translate.fedoraproject.org.
> The issue appears to be that guix/diagnostics.scm does not appear in
> guix/POTFILES.in.

I did that not long ago (after the release, unfortunately) in
fed83e52fed3808b437361d84c29c2870cab5458.

The relevant strings are commented out in .po files though, so we’ll
need a PO update to get them.

Thanks,
Ludo’.

Message #16 received at 49184-done <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49184-done <at> debbugs.gnu.org
Subject: Re: bug#49184: [PATCH]: Strings in (guix diagnostics) are not
 translated
Date: Fri, 25 Jun 2021 13:24:57 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op wo 23-06-2021 om 23:04 [+0200]:
> Hi,
> 
> Maxime Devos <maximedevos <at> telenet.be> skribis:
> 
> > These are currently not translated and don't appear on translate.fedoraproject.org.
> > The issue appears to be that guix/diagnostics.scm does not appear in
> > guix/POTFILES.in.
> 
> I did that not long ago (after the release, unfortunately) in
> fed83e52fed3808b437361d84c29c2870cab5458.

Seems like my local git worktree is in need of a "git rebase".
Thanks!

Greetigs,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.