GNU bug report logs - #49183
[PATCH] gnu: ocaml-dose3: Fix tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49183 in the body.
You can then email your comments to 49183 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ocaml-dose3: Fix tests.
Date: Wed, 23 Jun 2021 10:52:38 +0200

* gnu/packages/ocaml.scm (ocaml-dose3)[arguments]<#:phases>: Add phase to
patch tests script.
---
The test script was failing to run without this, which also caused
emacs-tuareg to not build.

No idea why one would use Python to test OCaml code...

 gnu/packages/ocaml.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index dd30f4cc97..1262c0e303 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -647,7 +647,14 @@ underlying solvers like Cplex, Gurobi, Lpsolver, Glpk, CbC, SCIP or WBO.")
        #:make-flags
        (list (string-append "LIBDIR="
                             (assoc-ref %outputs "out")
-                            "/lib/ocaml/site-lib"))))
+                            "/lib/ocaml/site-lib"))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-test-script
+           (lambda _
+             (substitute* "applications/dose-tests.py"
+               (("warning\\(")
+                "from warnings import warn\nwarn(")))))))
     (propagated-inputs
       `(("ocaml-graph" ,ocaml-graph)
         ("ocaml-cudf" ,ocaml-cudf)

base-commit: 4605ea1a780ff5889b7273d27a255294d7a08327
-- 
2.32.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pukkamustard <pukkamustard <at> posteo.net>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 49171 <at> debbugs.gnu.org, 49183 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests.
Date: Wed, 23 Jun 2021 11:09:44 +0000

Neat. Thanks!

Fixes the test and looks got to me.

> No idea why one would use Python to test OCaml code...

Yeah, makes one wonder. At least they've updated to Python3 
(https://gitlab.com/irill/dose3/-/blob/master/CHANGES#L33) 
recently.

Message #16 received at 49183-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: pukkamustard <pukkamustard <at> posteo.net>
Cc: 49183-done <at> debbugs.gnu.org, 49171-done <at> debbugs.gnu.org,
 Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: [bug#49183] [PATCH] gnu: ocaml-dose3: Fix tests.
Date: Wed, 23 Jun 2021 14:45:52 +0200

Le Wed, 23 Jun 2021 11:09:44 +0000,
pukkamustard <pukkamustard <at> posteo.net> a écrit :

> Neat. Thanks!
> 
> Fixes the test and looks got to me.
> 
> > No idea why one would use Python to test OCaml code...  
>  
> Yeah, makes one wonder. At least they've updated to Python3 
> (https://gitlab.com/irill/dose3/-/blob/master/CHANGES#L33) 
> recently.
> 
> 
> 

Thanks! Pushed as 91b29aa37394b660117e1d79927621db1344b7fe.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.