GNU bug report logs - #49170
[PATCH] New package: python-fire

Previous Next

Full log

Message #25 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49170 <at> debbugs.gnu.org,
 دانیال بهزادی <dani.behzi <at> ubuntu.com>
Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Mon, 28 Jun 2021 17:50:44 -0400

[Message part 1 (text/plain, inline)]

Hi Maxim!

> I'm a bit late, as this has already been merged,
> but this should have been something like:
> 
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               (invoke "pytest")))))))

Ah my bad to miss it. Thanks for catching it.

> That way, tests can be disabled with "--without-tests".
> Try "./pre-inst-env guix build pytest --without-tests=pytests".
> Respecting #:tests? can also be important for cross-compilation.
> 
> Could you send a follow-up patch, or could someone directly
> commit such a change?

I pushed as e61874a598.

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.