GNU bug report logs - #49170
[PATCH] New package: python-fire

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49170 in the body.
You can then email your comments to 49170 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danial Behzadi <dani.behzi <at> ubuntu.com>
To: guix-patches <at> gnu.org
Cc: Danial Behzadi <dani.behzi <at> ubuntu.com>
Subject: [PATCH] New package: python-fire
Date: Tue, 22 Jun 2021 18:03:26 +0430

---
 gnu/packages/python-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 1268ff257a..7ce0ada5ea 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -1410,6 +1410,43 @@ the version levels, and check whether any given string is a proper semantic
 version identifier.")
     (license license:bsd-3)))
 
+(define-public python-fire
+  (package
+    (name "python-fire")
+    (version "0.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "fire" version))
+       (sha256
+        (base32
+         "0qka44n88y3qcj7xz0k0f3qb4phcg4z0wvd4jcii9lcr6rvbiqn5"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-pytest", python-pytest)))
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _ (invoke "pytest"))))))
+    (inputs
+     `(("python-six", python-six)
+       ("python-termcolor", python-termcolor)))
+    (synopsis "Library for automatically generating command line interfaces")
+    (description
+     "Python Fire is a library for automatically generating command line interfaces
+     (CLIs) from absolutely any Python object.
+
+     * Python Fire is a simple way to create a CLI in Python.
+     * Python Fire is a helpful tool for developing and debugging Python code.
+     * Python Fire helps with exploring existing code or turning other people's
+    code into a CLI.
+     * Python Fire makes transitioning between Bash and Python easier.
+     * Python Fire makes using a Python REPL easier by setting up the REPL with
+    the modules and variables you'll need already imported and created.")
+    (home-page "https://github.com/google/python-fire")
+    (license license:asl2.0)))
+
 (define-public python2-semantic-version
   (package-with-python2 python-semantic-version))
 
-- 
2.31.1

Message #8 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: دانیال بهزادی <dani.behzi <at> ubuntu.com>
To: 49170 <at> debbugs.gnu.org
Subject: [PATCH] New package: python-fire
Date: Sat, 26 Jun 2021 13:19:29 +0000

[Message part 1 (text/plain, inline)]

Any news on this?
Should I do any additional step?

[Message part 2 (text/html, inline)]

Message #11 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: دانیال بهزادی <dani.behzi <at> ubuntu.com>
To: 49170 <at> debbugs.gnu.org
Subject: [PATCH v2]: gnu: Add python-fire
Date: Sat, 26 Jun 2021 19:43:11 +0000

[Message part 1 (text/plain, inline)]

Changed a little in LibreMiami packaging event

[Message part 2 (text/html, inline)]

[0001-gnu-Add-python-fire.patch (text/x-diff, attachment)]

Message #14 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: دانیال بهزادی <dani.behzi <at> ubuntu.com>
To: 49170 <at> debbugs.gnu.org
Subject: [PATCH v2]: gnu: Add python-fire
Date: Sat, 26 Jun 2021 19:52:10 +0000

[Message part 1 (text/plain, inline)]

Sorry. The previous one was malformed. This is the correct one.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-python-fire.patch (text/x-diff, attachment)]

Message #19 received at 49170-done <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: 49170-done <at> debbugs.gnu.org
Date: Sat, 26 Jun 2021 16:06:23 -0400

[Message part 1 (text/plain, inline)]

Thank you for the contribution.

Pushed as 1f15a6559b.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #22 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: دانیال بهزادی
 <dani.behzi <at> ubuntu.com>, 49170 <at> debbugs.gnu.org
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Mon, 28 Jun 2021 23:30:46 +0200

[Message part 1 (text/plain, inline)]

> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _ (invoke "pytest"))))))

I'm a bit late, as this has already been merged,
but this should have been something like:

> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (invoke "pytest")))))))

That way, tests can be disabled with "--without-tests".
Try "./pre-inst-env guix build pytest --without-tests=pytests".
Respecting #:tests? can also be important for cross-compilation.

Could you send a follow-up patch, or could someone directly
commit such a change?

Greetings,
Maxime. 

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 49170 <at> debbugs.gnu.org,
 دانیال بهزادی <dani.behzi <at> ubuntu.com>
Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Mon, 28 Jun 2021 17:50:44 -0400

[Message part 1 (text/plain, inline)]

Hi Maxim!

> I'm a bit late, as this has already been merged,
> but this should have been something like:
> 
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               (invoke "pytest")))))))

Ah my bad to miss it. Thanks for catching it.

> That way, tests can be disabled with "--without-tests".
> Try "./pre-inst-env guix build pytest --without-tests=pytests".
> Respecting #:tests? can also be important for cross-compilation.
> 
> Could you send a follow-up patch, or could someone directly
> commit such a change?

I pushed as e61874a598.

Regards,
RG.

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #28 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: دانیال بهزادی <dani.behzi <at> ubuntu.com>
To: Maxime Devos <maximedevos <at> telenet.be>, 49170 <at> debbugs.gnu.org
Cc: Raghav Gururajan <rg <at> raghavgururajan.name>
Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Mon, 28 Jun 2021 21:57:04 +0000

[Message part 1 (text/plain, inline)]

This is awesome. I think Guix really lacks a very detailed document on packaging. Every patch I wrote is vastly based on apriority assumptions and lots of try and fails.

در 28 ژوئن 2021 21:30:46 (UTC)، Maxime Devos <maximedevos <at> telenet.be> نوشت:
>> +    (arguments
>> +     '(#:phases
>> +       (modify-phases %standard-phases
>> +         (replace 'check
>> +           (lambda _ (invoke "pytest"))))))
>
>I'm a bit late, as this has already been merged,
>but this should have been something like:
>
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               (invoke "pytest")))))))
>
>That way, tests can be disabled with "--without-tests".
>Try "./pre-inst-env guix build pytest --without-tests=pytests".
>Respecting #:tests? can also be important for cross-compilation.
>
>Could you send a follow-up patch, or could someone directly
>commit such a change?
>
>Greetings,
>Maxime. 

[Message part 2 (text/html, inline)]

Message #31 received at 49170 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: دانیال بهزادی
 <dani.behzi <at> ubuntu.com>, 49170 <at> debbugs.gnu.org
Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire
Date: Tue, 29 Jun 2021 10:06:04 +0200

[Message part 1 (text/plain, inline)]

دانیال بهزادی schreef op ma 28-06-2021 om 21:57 [+0000]:
> This is awesome. I think Guix really lacks a very detailed document on packaging.
> Every patch I wrote is vastly based on apriority assumptions and lots of try and fails.

Yes, not everything is in the manual.

FWIW, there should be a linter soonish verifying that #:tests? is respected:
<https://issues.guix.gnu.org/48320>. A sample of
'./pre-inst-env guix lint --no-network --exclude=derivation'
output ('derivation' is slow):

gnu/packages/astronomy.scm:898:5: python-jplephem <at> 2.15: the 'check' phase should respect #:tests?
gnu/packages/astronomy.scm:690:5: missfits <at> 2.8.0: sentences in description should be followed by two spaces; possible infraction at 268
gnu/packages/attr.scm:43:5: attr <at> 2.4.48: the 'check' phase should respect #:tests?
gnu/packages/audio.scm:5208:5: ableton-link <at> 3.0.2: the 'check' phase should respect #:tests?
gnu/packages/audio.scm:2484:2: audio-to-midi <at> 2020.7: 'python-cython' should probably be a native input
gnu/packages/audio.scm:2488:6: audio-to-midi <at> 2020.7: the source file name should contain the package name

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.