GNU bug report logs - #48892
[PATCH] gnu: Add xkbset.

Previous Next

Full log

View this message in rfc822 format

From: "Paul A. Patience" <paul <at> apatience.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "48892 <at> debbugs.gnu.org" <48892 <at> debbugs.gnu.org>
Subject: [bug#48892] [PATCH] gnu: Add xkbset.
Date: Mon, 07 Jun 2021 12:40:06 +0000

[Message part 1 (text/plain, inline)]

On Monday, June 7, 2021 6:04 AM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> You should do
>
> `(,,(string-append "CC=" (cc-for-target))
> ,(string-append "X11PREFIX=" ...) ...)

Fixed.
I suppose this needs to be fixed in many existing packages.
I hadn't seen cc-for-target until now.
(I also discovered %output in the meantime.)

> to make sure cross-compilation will work.
> (Try ./pre-inst-env guix build xkbset --target=aarch64-linux-gnu.)

Unfortunately it seems that:

    guix build: error: gnu/packages/tcl.scm:270:2: perl-tk <at> 804.034: build system `perl' does not support cross builds

> Also, libx11 is usualy named "libx11" (no capital letters)
> in package inputs, and very infrequently "libX11". I would use "libx11".

Fixed.
I also prefer all lowercase, but the one package I had
looked at to determine the X11 library to include had used uppercase.

The updated patch is attached.

Thanks for the help,
Paul

[0001-gnu-Add-xkbset.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.