GNU bug report logs - #48892
[PATCH] gnu: Add xkbset.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48892 in the body.
You can then email your comments to 48892 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add xkbset.
Date: Mon, 07 Jun 2021 00:37:32 +0000

[Message part 1 (text/plain, inline)]

Empty Message

[0001-gnu-Add-xkbset.patch (text/x-patch, attachment)]

Message #8 received at 48892 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "Paul A. Patience" <paul <at> apatience.com>, 48892 <at> debbugs.gnu.org
Subject: Re: [bug#48892] [PATCH] gnu: Add xkbset.
Date: Mon, 07 Jun 2021 12:04:29 +0200

[Message part 1 (text/plain, inline)]

Paul A. Patience schreef op ma 07-06-2021 om 00:37 [+0000]:
> +       (let ((out (assoc-ref %outputs "out")))
> +         `("CC=gcc"
> +           ,(string-append "X11PREFIX=" out)
> +           ,(string-append "X11BASE=" (assoc-ref %build-inputs "libX11"))
> +           ,(string-append "INSTALL_MAN1=" out "/share/man/man1")))

You should do

  `(,,(string-append "CC=" (cc-for-target))
    ,(string-append "X11PREFIX=" ...) ...)

to make sure cross-compilation will work.
(Try ./pre-inst-env guix build xkbset --target=aarch64-linux-gnu.)

Also, libx11 is usualy named "libx11" (no capital letters)
in package inputs, and very infrequently "libX11". I would use "libx11".

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 48892 <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "48892 <at> debbugs.gnu.org" <48892 <at> debbugs.gnu.org>
Subject: Re: [bug#48892] [PATCH] gnu: Add xkbset.
Date: Mon, 07 Jun 2021 12:40:06 +0000

[Message part 1 (text/plain, inline)]

On Monday, June 7, 2021 6:04 AM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> You should do
>
> `(,,(string-append "CC=" (cc-for-target))
> ,(string-append "X11PREFIX=" ...) ...)

Fixed.
I suppose this needs to be fixed in many existing packages.
I hadn't seen cc-for-target until now.
(I also discovered %output in the meantime.)

> to make sure cross-compilation will work.
> (Try ./pre-inst-env guix build xkbset --target=aarch64-linux-gnu.)

Unfortunately it seems that:

    guix build: error: gnu/packages/tcl.scm:270:2: perl-tk <at> 804.034: build system `perl' does not support cross builds

> Also, libx11 is usualy named "libx11" (no capital letters)
> in package inputs, and very infrequently "libX11". I would use "libx11".

Fixed.
I also prefer all lowercase, but the one package I had
looked at to determine the X11 library to include had used uppercase.

The updated patch is attached.

Thanks for the help,
Paul

[0001-gnu-Add-xkbset.patch (text/x-patch, attachment)]

Message #14 received at 48892 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: "48892 <at> debbugs.gnu.org" <48892 <at> debbugs.gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#48892: [PATCH] gnu: Add xkbset.
Date: Tue, 08 Jun 2021 23:23:05 +0200

Hi,

"Paul A. Patience" <paul <at> apatience.com> skribis:

> From 59a4d628e2179c8a768c7fdf5401f2f8193c6893 Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <paul <at> apatience.com>
> Date: Mon, 7 Jun 2021 08:34:43 -0400
> Subject: [PATCH] gnu: Add xkbset.
>
> * gnu/packages/xorg.scm (xkbset): New variable.

This should go to xdisorg.scm (xorg.scm is for packages distributed by
the X.org project).

> +    (synopsis "User-preference utility for XKB extensions for X")
> +    (description
> +     "This is a program to help manage many of the XKB features of the X
> +Window System. This includes such features as MouseKeys, AccessX,
> +StickyKeys, BounceKeys, and SlowKeys. It includes a GUI program to help
> +with MouseKeys-acceleration management.")

‘guix lint’ complains about two-spaces-after-period issues.  :-)

Also, s/GUI program/graphical program/ ?

Could you send an updated patch?  This should be the last one!

Thanks,
Ludo’.

Message #17 received at 48892 <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "48892 <at> debbugs.gnu.org" <48892 <at> debbugs.gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#48892: [PATCH] gnu: Add xkbset.
Date: Wed, 09 Jun 2021 12:18:22 +0000

[Message part 1 (text/plain, inline)]

On Tuesday, June 8th, 2021 at 17:23, Ludovic Courtès <ludo <at> gnu.org> wrote:

> This should go to xdisorg.scm (xorg.scm is for packages distributed by
> the X.org project).

<snip>

> ‘guix lint’ complains about two-spaces-after-period issues. :-)
>
> Also, s/GUI program/graphical program/ ?

Good catches!
The updated patch is attached.

Best regards,
Paul

[0001-gnu-Add-xkbset.patch (text/x-patch, attachment)]

Message #22 received at 48892-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: "48892 <at> debbugs.gnu.org" <48892-done <at> debbugs.gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#48892: [PATCH] gnu: Add xkbset.
Date: Sat, 12 Jun 2021 00:42:53 +0200

Hi,

"Paul A. Patience" <paul <at> apatience.com> skribis:

> From 65b9463e159f0e3ff1ae0c4a0faca08b0c22ed81 Mon Sep 17 00:00:00 2001
> From: "Paul A. Patience" <paul <at> apatience.com>
> Date: Wed, 9 Jun 2021 08:07:44 -0400
> Subject: [PATCH] gnu: Add xkbset.
>
> * gnu/packages/xdisorg.scm (xkbset): New variable.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.