GNU bug report logs - #48128
[PATCH] Add font-montserrat.

Previous Next

Full log

Message #8 received at 48128 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 48128 <at> debbugs.gnu.org
Subject: Re: bug#48128: [PATCH] Add font-montserrat.
Date: Mon, 03 May 2021 18:13:45 +0200

Hi Sergiu,

Sergiu Ivanov <sivanov <at> colimite.fr> skribis:

> I retrieve the release zipball from GitHub using a direct url-fetch
> rather than git-fetch, because I've seen both in fonts.scm. If you think
> git-fetch is more appropriate, I'll change the method.


[...]

> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))

This is a generated tarball that may change over time, which is why
‘guix lint’ warns about it.  So yes, I think you should use ‘git-fetch’
instead.

You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
lint’ suggests.

There are also a couple of ‘guix lint’ warnings that I’ll let you
check.  :-)

> +    (synopsis "The Montserat font")
                            ^
Missing ‘r’.

Could you send an updated patch?

Thanks in advance,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.