GNU bug report logs - #48128
[PATCH] Add font-montserrat.

Previous Next

Full log

View this message in rfc822 format

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48128 <at> debbugs.gnu.org
Subject: [bug#48128] [PATCH] Add font-montserrat.
Date: Wed, 05 May 2021 22:17:25 +0200

[Message part 1 (text/plain, inline)]

Hi Ludovic,

Thank you for taking the time to answer and giving me the opportunity
to learn!

Also, sorry for the delay.


Thus quoth  Ludovic Courtès  on Mon May 03 2021 at 18:13 (+0200):
> Hi Sergiu,
>
> Sergiu Ivanov <sivanov <at> colimite.fr> skribis:
>
>> I retrieve the release zipball from GitHub using a direct url-fetch
>> rather than git-fetch, because I've seen both in fonts.scm. If you think
>> git-fetch is more appropriate, I'll change the method.
>
>
> [...]
>
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))
>
> This is a generated tarball that may change over time, which is why
> ‘guix lint’ warns about it.  So yes, I think you should use ‘git-fetch’
> instead.

I changed that, thank you.

> You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
> lint’ suggests.

Indeed, I added that field.

> There are also a couple of ‘guix lint’ warnings that I’ll let you
> check.  :-)

I left closing parens on a separate line :O :O :O

I remember thinking how guix lint was wonderful when I read the Guix
Manual, and now I forgot to run it :D

>> +    (synopsis "The Montserat font")
>                             ^
> Missing ‘r’.

Fixed, thank you.

> Could you send an updated patch?

I attach the update.

-
Sergiu

[0001-Add-font-montserrat.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.