GNU bug report logs - #48031
28.0.50; comp-tests oddities

Previous Next

Full log

View this message in rfc822 format

From: Andrea Corallo <akrl <at> sdf.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 48031 <at> debbugs.gnu.org
Subject: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 16:46:39 +0000

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Hi Michael,
>
> Hi Andrea,
>
>> as of 9d34fd8b33 both issues should be solved, could you have a look if
>> it works for you too?
>
> LGTM.
>
> Btw, in ert-x.el we have the macros `ert-resource-directory' and
> `ert-resource-file'.
>
> (defconst comp-test-directory (concat (file-name-directory
>                                        (or load-file-name
>                                            buffer-file-name))
>                                       "comp-tests-resources/"))
>
>
> could be
>
> (defconst comp-test-directory (ert-resource-directory)
>
>
> (or just be removed), and
>
> (defconst comp-test-src
>   (expand-file-name "comp-test-funcs.el" comp-test-directory))

Nice!

In this case I guess we have to rename "test/src/comp-tests-resources/"
into "test/src/comp-resources/" would this be okay?

Thanks

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.