GNU bug report logs - #48031
28.0.50; comp-tests oddities

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48031 in the body.
You can then email your comments to 48031 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 11:37:27 +0200

comp-tests.el needs some care:

- The files test/src/comp-test-45603.el, test/src/comp-test-funcs.el,
  test/src/comp-test-funcs-dyn.el and test/src/comp-test-pure.el are
  data files. They shall be moved to the (new) directory
  test/src/comp-tests-resources.

- Running comp-tests results in errors:

--8<---------------cut here---------------start------------->8---
albinus <at> gandalf emacs]$ make -C test comp-tests
make: Entering directory '/usr/local/src/emacs/test'
make[1]: Entering directory '/usr/local/src/emacs/test'
  ELC      src/comp-tests.elc

In toplevel form:
src/comp-tests.el:30:1: Error: Symbol's value as variable is void: comp-ctxt
make[1]: *** [Makefile:158: src/comp-tests.elc] Error 1
make[1]: Leaving directory '/usr/local/src/emacs/test'
make: *** [Makefile:246: src/comp-tests] Error 2
make: Leaving directory '/usr/local/src/emacs/test'
--8<---------------cut here---------------end--------------->8---

Note, that I haven't enabled --with-native-compilation.


In GNU Emacs 28.0.50 (build 38, x86_64-pc-linux-gnu, GTK+ Version 3.24.28, cairo version 1.16.0)
 of 2021-04-26 built on gandalf
Repository revision: a9560a2b51191bbd832641fb8b0f9d88e89b5d36
Repository branch: master
Windowing system distributor 'Fedora Project', version 11.0.12010000
System Description: Fedora 33 (Workstation Edition)

Configured using:
 'configure --with-file-notification=gfile'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NOTIFY GFILENOTIFY
PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE
XIM XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8

Major mode: Group

Minor modes in effect:
  gnus-undo-mode: t
  display-time-mode: t
  shell-dirtrack-mode: t
  delete-selection-mode: t
  icomplete-mode: t
  show-paren-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/albinus/.emacs.d/elpa/transient-20210420.1635/transient hides /home/albinus/src/emacs/lisp/transient
/home/albinus/src/tramp/lisp/tramp-sh hides /home/albinus/src/emacs/lisp/net/tramp-sh
/home/albinus/src/tramp/lisp/tramp-fuse hides /home/albinus/src/emacs/lisp/net/tramp-fuse
/home/albinus/src/tramp/lisp/tramp-cmds hides /home/albinus/src/emacs/lisp/net/tramp-cmds
/home/albinus/src/tramp/lisp/tramp-gvfs hides /home/albinus/src/emacs/lisp/net/tramp-gvfs
/home/albinus/src/tramp/lisp/tramp-ftp hides /home/albinus/src/emacs/lisp/net/tramp-ftp
/home/albinus/src/tramp/lisp/tramp-crypt hides /home/albinus/src/emacs/lisp/net/tramp-crypt
/home/albinus/src/tramp/lisp/tramp-adb hides /home/albinus/src/emacs/lisp/net/tramp-adb
/home/albinus/src/tramp/lisp/tramp hides /home/albinus/src/emacs/lisp/net/tramp
/home/albinus/src/tramp/lisp/tramp-cache hides /home/albinus/src/emacs/lisp/net/tramp-cache
/home/albinus/src/tramp/lisp/tramp-rclone hides /home/albinus/src/emacs/lisp/net/tramp-rclone
/home/albinus/src/tramp/lisp/tramp-compat hides /home/albinus/src/emacs/lisp/net/tramp-compat
/home/albinus/src/tramp/lisp/tramp-integration hides /home/albinus/src/emacs/lisp/net/tramp-integration
/home/albinus/src/tramp/lisp/tramp-archive hides /home/albinus/src/emacs/lisp/net/tramp-archive
~/lisp/dbus hides /home/albinus/src/emacs/lisp/net/dbus
/home/albinus/src/tramp/lisp/tramp-sudoedit hides /home/albinus/src/emacs/lisp/net/tramp-sudoedit
/home/albinus/src/tramp/lisp/tramp-loaddefs hides /home/albinus/src/emacs/lisp/net/tramp-loaddefs
/home/albinus/src/tramp/lisp/tramp-uu hides /home/albinus/src/emacs/lisp/net/tramp-uu
/home/albinus/src/tramp/lisp/tramp-sshfs hides /home/albinus/src/emacs/lisp/net/tramp-sshfs
/home/albinus/src/tramp/lisp/tramp-smb hides /home/albinus/src/emacs/lisp/net/tramp-smb
/home/albinus/src/tramp/lisp/trampver hides /home/albinus/src/emacs/lisp/net/trampver

Features:
(shadow sort mail-extr warnings emacsbug pop3 utf-7 nndraft nnmh nnml
gnutls network-stream nsm gnus-agent gnus-srvr gnus-score score-mode
nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig
gnus-cache gnus-sum shr kinsoku svg dom nnnil smtpmail sendmail
gnus-demon nntp gnus-group gnus-undo gnus-start gnus-dbus dbus xml
gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int
gnus-range message rmc puny rfc822 mml mml-sec epa derived epg
epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail
rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search
mail-utils mm-util mail-prsvr wid-edit edmacro kmacro face-remap
ob-shell ob ob-tangle ol org-src ob-ref ob-lob ob-table ob-exp ob-comint
ob-core ob-eval org-keys org-compat advice org-macs vc vc-dispatcher
cperl-mode rx facemenu time tramp-sh docker-tramp kubernetes-tramp
tramp-cache lxc-tramp lxd-tramp tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat shell pcomplete comint ansi-color
ring parse-time iso8601 time-date ls-lisp format-spec delsel ido
jka-compr icomplete paren dired dired-loaddefs info package browse-url
url url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq
eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map
url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
gfilenotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 194536 8221)
 (symbols 48 19787 1)
 (strings 32 65350 3687)
 (string-bytes 1 2347664)
 (vectors 16 34553)
 (vector-slots 8 401072 10106)
 (floats 8 238 602)
 (intervals 56 396 0)
 (buffers 992 21))

Message #8 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 11:45:50 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

> - Running comp-tests results in errors:
>
> albinus <at> gandalf emacs]$ make -C test comp-tests
> make: Entering directory '/usr/local/src/emacs/test'
> make[1]: Entering directory '/usr/local/src/emacs/test'
>   ELC      src/comp-tests.elc
>
> In toplevel form:
> src/comp-tests.el:30:1: Error: Symbol's value as variable is void: comp-ctxt
> make[1]: *** [Makefile:158: src/comp-tests.elc] Error 1
> make[1]: Leaving directory '/usr/local/src/emacs/test'
> make: *** [Makefile:246: src/comp-tests] Error 2
> make: Leaving directory '/usr/local/src/emacs/test'
>
> Note, that I haven't enabled --with-native-compilation.

Oops, this is mentioned already in bug#48021.

Best regards, Michael.

Message #11 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 15:40:36 +0000

Michael Albinus <michael.albinus <at> gmx.de> writes:

> comp-tests.el needs some care:
>
> - The files test/src/comp-test-45603.el, test/src/comp-test-funcs.el,
>   test/src/comp-test-funcs-dyn.el and test/src/comp-test-pure.el are
>   data files. They shall be moved to the (new) directory
>   test/src/comp-tests-resources.
>
> - Running comp-tests results in errors:

[...]

Hi Michael,

as of 9d34fd8b33 both issues should be solved, could you have a look if
it works for you too?

Thanks for reporting, regards

  Andrea

Message #14 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 18:16:49 +0200

Andrea Corallo <akrl <at> sdf.org> writes:

> Hi Michael,

Hi Andrea,

> as of 9d34fd8b33 both issues should be solved, could you have a look if
> it works for you too?

LGTM.

Btw, in ert-x.el we have the macros `ert-resource-directory' and
`ert-resource-file'.

--8<---------------cut here---------------start------------->8---
(defconst comp-test-directory (concat (file-name-directory
                                       (or load-file-name
                                           buffer-file-name))
                                      "comp-tests-resources/"))
--8<---------------cut here---------------end--------------->8---

could be

--8<---------------cut here---------------start------------->8---
(defconst comp-test-directory (ert-resource-directory)
--8<---------------cut here---------------end--------------->8---

(or just be removed), and

--8<---------------cut here---------------start------------->8---
(defconst comp-test-src
  (expand-file-name "comp-test-funcs.el" comp-test-directory))
--8<---------------cut here---------------end--------------->8---

could be

--8<---------------cut here---------------start------------->8---
(defconst comp-test-src (ert-resource-file "comp-test-funcs.el")
--8<---------------cut here---------------end--------------->8---

etc pp.

> Thanks for reporting, regards
>
>   Andrea

Best regards, Michael.

PS: Could you, pls, introduce tag :nativecomp in test/README? Thanks.

Message #17 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 16:46:39 +0000

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Hi Michael,
>
> Hi Andrea,
>
>> as of 9d34fd8b33 both issues should be solved, could you have a look if
>> it works for you too?
>
> LGTM.
>
> Btw, in ert-x.el we have the macros `ert-resource-directory' and
> `ert-resource-file'.
>
> (defconst comp-test-directory (concat (file-name-directory
>                                        (or load-file-name
>                                            buffer-file-name))
>                                       "comp-tests-resources/"))
>
>
> could be
>
> (defconst comp-test-directory (ert-resource-directory)
>
>
> (or just be removed), and
>
> (defconst comp-test-src
>   (expand-file-name "comp-test-funcs.el" comp-test-directory))

Nice!

In this case I guess we have to rename "test/src/comp-tests-resources/"
into "test/src/comp-resources/" would this be okay?

Thanks

  Andrea

Message #20 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 19:30:13 +0200

Andrea Corallo <akrl <at> sdf.org> writes:

Hi Andrea,

> In this case I guess we have to rename "test/src/comp-tests-resources/"
> into "test/src/comp-resources/" would this be okay?

Of course, I gave you the wrong advice. Sorry.

> Thanks
>
>   Andrea

Best regards, Michael.

Message #23 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 18:07:33 +0000

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
> Hi Andrea,
>
>> In this case I guess we have to rename "test/src/comp-tests-resources/"
>> into "test/src/comp-resources/" would this be okay?
>
> Of course, I gave you the wrong advice. Sorry.
>
>> Thanks
>>
>>   Andrea
>
> Best regards, Michael.

Hi Michael,

I think with 449045b2a6 we should be okay WDYT?

Thanks for the suggestions

  Andrea

Message #26 received at 48031 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: 48031 <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 21:12:39 +0200

Andrea Corallo <akrl <at> sdf.org> writes:

> Hi Michael,

Hi Andrea,

> I think with 449045b2a6 we should be okay WDYT?

Yes, I believe so. The compilation of test/src/comp-tests.el shows
several compilation warnings, but this is another story, and I'm
confident you'll fix it as well.

You could close this bug from my pov.

> Thanks for the suggestions
>
>   Andrea

Best regards, Michael.

Message #31 received at 48031-done <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <akrl <at> sdf.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 48031-done <at> debbugs.gnu.org
Subject: Re: bug#48031: 28.0.50; comp-tests oddities
Date: Mon, 26 Apr 2021 20:13:23 +0000

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Andrea Corallo <akrl <at> sdf.org> writes:
>
>> Hi Michael,
>
> Hi Andrea,
>
>> I think with 449045b2a6 we should be okay WDYT?
>
> Yes, I believe so. The compilation of test/src/comp-tests.el shows
> several compilation warnings, but this is another story, and I'm
> confident you'll fix it as well.

ATM I'm not 100% sure we can remove all the warnings but I certainly
have a look.

> You could close this bug from my pov.

Doing that, thanks :)

Thanks

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.