GNU bug report logs - #47620
[PATCH] Allow complex key bindings in project-switch-project

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#47620: closed ([PATCH] Allow complex key bindings in
 project-switch-project)
Date: Wed, 07 Apr 2021 00:29:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 7 Apr 2021 03:28:27 +0300
with message-id <34e7eb22-597a-985c-5172-130f8bebde86 <at> yandex.ru>
and subject line Re: bug#47620: [PATCH] Allow complex key bindings in project-switch-project
has caused the debbugs.gnu.org bug report #47620,
regarding [PATCH] Allow complex key bindings in project-switch-project
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
47620: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=47620
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow complex key bindings in project-switch-project
Date: Tue, 06 Apr 2021 16:57:31 +0200

[Message part 3 (text/plain, inline)]

Hi,

project-switch-project currently only allows for single-char bindings to
be used for its commands.  Starting with emacs -Q, evaluate

    (require 'project)
    (define-key project-prefix-map (kbd "M-s g") 'rgrep)
    (add-to-list 'project-switch-commands '(rgrep "grep"))

and then run project-switch-project (by default bound to C-x p p) and
choose a project (hopefully you already have one available).  You will
see "[M-s g] grep" shown in the prompt, but you will not be able to
choose it by typing M-s g.

The patch attached bellow allows for any kind of key binding to be used.
Admittedly, there may be a better way to do it since I did not spend
much time looking into it.

Please, share your thoughts.

Best regards,
Dario

[0001-Allow-complex-key-bindings-in-project-switch-project.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid

[Message part 6 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>, 47620-done <at> debbugs.gnu.org
Subject: Re: bug#47620: [PATCH] Allow complex key bindings in
 project-switch-project
Date: Wed, 7 Apr 2021 03:28:27 +0300

Hi Dario,

On 06.04.2021 17:57, Dario Gjorgjevski wrote:

> project-switch-project currently only allows for single-char bindings to
> be used for its commands.  Starting with emacs -Q, evaluate
> 
>      (require 'project)
>      (define-key project-prefix-map (kbd "M-s g") 'rgrep)
>      (add-to-list 'project-switch-commands '(rgrep "grep"))
> 
> and then run project-switch-project (by default bound to C-x p p) and
> choose a project (hopefully you already have one available).  You will
> see "[M-s g] grep" shown in the prompt, but you will not be able to
> choose it by typing M-s g.
> 
> The patch attached bellow allows for any kind of key binding to be used.
> Admittedly, there may be a better way to do it since I did not spend
> much time looking into it.
> 
> Please, share your thoughts.

Thanks for the patch, it's a nice addition.

Note that it broke the ability to 'C-g' out of the second prompt, see 
the follow-up commit 1ff7cde102.

Likewise, any proposals with a better way to do this are welcome.

(Meantime, closing.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.