GNU bug report logs - #47620
[PATCH] Allow complex key bindings in project-switch-project

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47620 in the body.
You can then email your comments to 47620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow complex key bindings in project-switch-project
Date: Tue, 06 Apr 2021 16:57:31 +0200

[Message part 1 (text/plain, inline)]

Hi,

project-switch-project currently only allows for single-char bindings to
be used for its commands.  Starting with emacs -Q, evaluate

    (require 'project)
    (define-key project-prefix-map (kbd "M-s g") 'rgrep)
    (add-to-list 'project-switch-commands '(rgrep "grep"))

and then run project-switch-project (by default bound to C-x p p) and
choose a project (hopefully you already have one available).  You will
see "[M-s g] grep" shown in the prompt, but you will not be able to
choose it by typing M-s g.

The patch attached bellow allows for any kind of key binding to be used.
Admittedly, there may be a better way to do it since I did not spend
much time looking into it.

Please, share your thoughts.

Best regards,
Dario

[0001-Allow-complex-key-bindings-in-project-switch-project.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid

Message #10 received at 47620-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>, 47620-done <at> debbugs.gnu.org
Subject: Re: bug#47620: [PATCH] Allow complex key bindings in
 project-switch-project
Date: Wed, 7 Apr 2021 03:28:27 +0300

Hi Dario,

On 06.04.2021 17:57, Dario Gjorgjevski wrote:

> project-switch-project currently only allows for single-char bindings to
> be used for its commands.  Starting with emacs -Q, evaluate
> 
>      (require 'project)
>      (define-key project-prefix-map (kbd "M-s g") 'rgrep)
>      (add-to-list 'project-switch-commands '(rgrep "grep"))
> 
> and then run project-switch-project (by default bound to C-x p p) and
> choose a project (hopefully you already have one available).  You will
> see "[M-s g] grep" shown in the prompt, but you will not be able to
> choose it by typing M-s g.
> 
> The patch attached bellow allows for any kind of key binding to be used.
> Admittedly, there may be a better way to do it since I did not spend
> much time looking into it.
> 
> Please, share your thoughts.

Thanks for the patch, it's a nice addition.

Note that it broke the ability to 'C-g' out of the second prompt, see 
the follow-up commit 1ff7cde102.

Likewise, any proposals with a better way to do this are welcome.

(Meantime, closing.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.