GNU bug report logs - #47274
Linphone Packages

Previous Next

Full log

Message #56 received at 47274 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <rg <at> raghavgururajan.name>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 47274 <at> debbugs.gnu.org, Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: Re: bug#47274: Linphone Packages
Date: Mon, 29 Mar 2021 01:07:23 -0400

[Message part 1 (text/plain, inline)]

Hi Maxim!

> Ending phases with #t is no longer required on core-updates, and we can
> stop doing it on master and staging already too, to save us the hassle
> of editing them out at some later point in time :-)

Agreed.

> This inputs field seems unnecessary, especially we don't want to add a
> dependency to Python 2, which is slowly being carved out of Guix.

Makes sense.

> I've made the following changes:
> 
> --8<---------------cut here---------------start------------->8---
> 1 file changed, 5 insertions(+), 15 deletions(-)
> gnu/packages/crypto.scm | 20 +++++---------------
> 
> modified   gnu/packages/crypto.scm
> @@ -116,40 +116,30 @@
>                  (("gmake")
>                   "make")
>                  (("'\\.\\.', 'build', 'lib', 'libdecaf\\.so'")
> -                "'..', '..', 'build', 'src', 'libdecaf.so'"))
> -             #t))
> +                "'..', '..', 'build', 'src', 'libdecaf.so'"))))
>            (add-after 'install 'install-python-binding
>              (lambda* (#:key outputs #:allow-other-keys)
>                (with-directory-excursion "../source/python"
>                  (invoke "python" "setup.py" "install"
>                          (string-append "--prefix=" (assoc-ref outputs "python"))
> -                       "--root=/"))
> -             #t))
> +                       "--root=/"))))
>            (add-after 'install-python-binding 'install-documentation
>              (lambda* (#:key outputs #:allow-other-keys)
>                (invoke "make" "doc")
>                (let* ((doc (assoc-ref outputs "doc"))
>                       (dest (string-append doc "/share/doc")))
> -               (copy-recursively "doc" dest))
> -             #t)))))
> +               (copy-recursively "doc" dest)))))))
>       (native-inputs
>        `(("dot" ,graphviz)
>          ("doxygen" ,doxygen)
>          ("python" ,python-wrapper)))
> -    (inputs
> -     `(("python2" ,python-2.7)
> -       ("python3" ,python)))
>       (synopsis "Decaf Elliptic Curve Library")
>       (description "The libdecaf library is an implementation of elliptic curve
>   cryptography using the Montgomery and Edwards curves Curve25519, Ed25519,
>   Ed448-Goldilocks and Curve448, using the Decaf encoding.")
>       (home-page "http://ed448goldilocks.sourceforge.net/")
> -    (license
> -     (list
> -      ;; Library.
> -      license:expat
> -      ;; Binding.
> -      license:bsd-2))))
> +    (license (list license:expat        ;library
> +                   license:bsd-2))))    ;python bindings
>   
>   (define-public libsodium
>     (package
> --8<---------------cut here---------------end--------------->8---
> 
> And pushed as commit c221d49510.

Thank you!

Regards,
RG.

[OpenPGP_0x5F5816647F8BE551.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.