GNU bug report logs - #4727
23.1; `multi-isearch-(files|buffers)(-regexp)'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: "Drew Adams" <drew.adams <at> oracle.com>
Subject: bug#4727 closed by Juri Linkov <juri <at> jurta.org> (Re: bug#4727:
 23.1; `multi-isearch-(files|buffers)(-regexp)')
Date: Mon, 30 Nov 2009 20:35:04 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'

It has been closed by Juri Linkov <juri <at> jurta.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Juri Linkov <juri <at> jurta.org> by
replying to this email.


-- 
4727: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4727
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 4727-done <at> debbugs.gnu.org
Subject: Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Mon, 30 Nov 2009 22:28:12 +0200

>> However, we could convert relative file names to internal absolute
>> file names before starting multi-file Isearch.  So you will be able
>> to specify file names relative to the default directory where
>> multi-file Isearch was started.
>
> That was what I was thinking.

Thanks for the idea.  Implemented.

>> Similarly, we could convert buffer names to internal live buffers
>> before starting multi-buffer Isearch.
>
> Why not? That's pretty standard. Let the function do the work of calling
> `get-buffer'.

This is implemented as well.

-- 
Juri Linkov
http://www.jurta.org/emacs/

[Message part 3 (message/rfc822, inline)]

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Wed, 14 Oct 2009 17:27:56 -0700

1. The doc strings of `multi-isearch-files(-regexp)' need to say that
each of the FILES elements must be an absolute file name. I was trying
to make it work with relative names, and I wasted a lot of time
debugging. It was only when the debugger finally got to comparing
`buffer-file-name' with the FILES element that I saw the problem.
 
2. Why not let these functions accept either absolute or relative file
names?  If relative, they should be interpreted relative to
`default-directory'.
 
3. Similarly, for `multi-isearch-buffers(-regexp)': 
 
a. The doc strings need to say explicitly that the BUFFERS must be
live buffers, not their names.
 
b. Why should the BUFFERS need to be buffers - why not also allow
buffer names?
 
The code is unnecessarily restrictive/brittle.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.