GNU bug report logs - #4727
23.1; `multi-isearch-(files|buffers)(-regexp)'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4727 in the body.
You can then email your comments to 4727 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Wed, 14 Oct 2009 17:27:56 -0700

1. The doc strings of `multi-isearch-files(-regexp)' need to say that
each of the FILES elements must be an absolute file name. I was trying
to make it work with relative names, and I wasted a lot of time
debugging. It was only when the debugger finally got to comparing
`buffer-file-name' with the FILES element that I saw the problem.
 
2. Why not let these functions accept either absolute or relative file
names?  If relative, they should be interpreted relative to
`default-directory'.
 
3. Similarly, for `multi-isearch-buffers(-regexp)': 
 
a. The doc strings need to say explicitly that the BUFFERS must be
live buffers, not their names.
 
b. Why should the BUFFERS need to be buffers - why not also allow
buffer names?
 
The code is unnecessarily restrictive/brittle.
 
 
 

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 

Message #10 received at 4727 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 4727 <at> debbugs.gnu.org
Subject: Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Fri, 16 Oct 2009 00:28:46 +0300

> 1. The doc strings of `multi-isearch-files(-regexp)' need to say that
> each of the FILES elements must be an absolute file name. I was trying
> to make it work with relative names, and I wasted a lot of time
> debugging. It was only when the debugger finally got to comparing
> `buffer-file-name' with the FILES element that I saw the problem.
>
> 2. Why not let these functions accept either absolute or relative file
> names?  If relative, they should be interpreted relative to
> `default-directory'.

Using relative file names will make these functions unreliable and
non-deterministic.  For instance, when you create a list of file names
in subdirectories relative to the current directory '("./dir1/file1"
"./dir2/file2") and multi-isearch visits file1 in the first subdir dir1,
then going to the next file "./dir2/file2" relative to the base dir
will fail in dir1.

However, we could convert relative file names to internal absolute
file names before starting multi-file Isearch.  So you will be able
to specify file names relative to the default directory where
multi-file Isearch was started.

> 3. Similarly, for `multi-isearch-buffers(-regexp)':
>
> a. The doc strings need to say explicitly that the BUFFERS must be
> live buffers, not their names.
>
> b. Why should the BUFFERS need to be buffers - why not also allow
> buffer names?
>
> The code is unnecessarily restrictive/brittle.

Similarly, we could convert buffer names to internal live buffers
before starting multi-buffer Isearch.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #15 received at 4727 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Juri Linkov'" <juri <at> jurta.org>
Cc: <4727 <at> debbugs.gnu.org>
Subject: RE: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Thu, 15 Oct 2009 15:52:18 -0700

> However, we could convert relative file names to internal absolute
> file names before starting multi-file Isearch.  So you will be able
> to specify file names relative to the default directory where
> multi-file Isearch was started.

That was what I was thinking.

> > 3. Similarly, for `multi-isearch-buffers(-regexp)':
> >
> > a. The doc strings need to say explicitly that the BUFFERS must be
> > live buffers, not their names.
> >
> > b. Why should the BUFFERS need to be buffers - why not also allow
> > buffer names?
> >
> > The code is unnecessarily restrictive/brittle.
> 
> Similarly, we could convert buffer names to internal live buffers
> before starting multi-buffer Isearch.

Why not? That's pretty standard. Let the function do the work of calling
`get-buffer'.

Message #20 received at 4727-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 4727-done <at> debbugs.gnu.org
Subject: Re: bug#4727: 23.1; `multi-isearch-(files|buffers)(-regexp)'
Date: Mon, 30 Nov 2009 22:28:12 +0200

>> However, we could convert relative file names to internal absolute
>> file names before starting multi-file Isearch.  So you will be able
>> to specify file names relative to the default directory where
>> multi-file Isearch was started.
>
> That was what I was thinking.

Thanks for the idea.  Implemented.

>> Similarly, we could convert buffer names to internal live buffers
>> before starting multi-buffer Isearch.
>
> Why not? That's pretty standard. Let the function do the work of calling
> `get-buffer'.

This is implemented as well.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.