GNU bug report logs - #46842
[PATCH] gnu: gnuradio: Updated to 3.9.0.0.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: João Pedro Simas <jpsimas <at> gmail.com>
Cc: 46842 <at> debbugs.gnu.org
Subject: [bug#46842] [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Sun, 21 Mar 2021 23:40:14 +0100

[Message part 1 (text/plain, inline)]

Hi,

João Pedro Simas <jpsimas <at> gmail.com> skribis:

> Hi,
> Sorry, this took a bit more time than I expected, but now I think I've
> figured it out.
>
> About the bundled copy of volk, it was removed in this commit
> https://github.com/gnuradio/gnuradio/commit/80c04479da962d048d41165081b026aafdaa0316,
> that is included in 3.9.0.0. I've also removed the:
>>         '("-DENABLE_INTERNAL_VOLK=OFF")
> configure-flag because the env var is not used anymore in gnuradio.

OK.

> I've also added the urls of the issues concerning the tests, but, in the
> end, I found that one of the tests (qa_dtv) was failing due to sdl not
> being included as an input and there, so I've included it, and that there's
> another test that fails, but intermittently (qa_packet_headerparser_b) so I
> disabled it in addition to the original one (qa_header_payload_demux).
>
> I also realized I had forgotten to add a change to the patch file related
> to the lines that patch the references to codec2 inside a swig file that
> was removed in 3.9, because swig was replaced with pybind11. I've added
> that too.
>
> Finally, I wrote the changelog in the commit log. The updated patch file is
> attached.

The patch LGTM but I got this one ‘qa_dtv’ test failure on x86_64:

--8<---------------cut here---------------start------------->8---
222/241 Test #226: qa_cvsd_vocoder ..............................   Passed    1.18 sec
        Start 230: qa_ulaw_vocoder
223/241 Test #228: qa_g723_24_vocoder ...........................   Passed    0.93 sec
        Start 231: qa_codec2_vocoder
224/241 Test #218: qa_dtv .......................................***Failed    3.73 sec
F
======================================================================
FAIL: test_000 (__main__.test_dtv)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gr-dtv/python/dtv/qa_dtv.py", line 171, in test_000
    self.assertFloatTuplesAlmostEqual(out_data, expected_data, 5)
  File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gnuradio-runtime/python/gnuradio/gr_unittest.py", line 96, in assertFloatTuplesAlmostEqual
    return all([
  File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gnuradio-runtime/python/gnuradio/gr_unittest.py", line 97, in <listcomp>
    self.assertAlmostEqual(x, y, places, msg)
AssertionError: -0.0002739299 != -0.0011434406 within 5 places (0.0008695107 difference)

----------------------------------------------------------------------
Ran 1 test in 2.559s

FAILED (failures=1)
--8<---------------cut here---------------end--------------->8---

Does that ring a bell?

Attached is a variant of the patch where I adjusted indentation to
follow our conventions.

BTW, please send patches as attachments in the future (this one had been
mangled on its way).

Thanks,
Ludo’.

PS: Please keep the bug Cc’d.

[0001-gnu-gnuradio-Update-to-3.9.0.0.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.