GNU bug report logs - #46842
[PATCH] gnu: gnuradio: Updated to 3.9.0.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46842 in the body.
You can then email your comments to 46842 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: João <jpsimas <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: João <jpsimas <at> gmail.com>
Subject: [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Mon,  1 Mar 2021 00:56:22 -0300

---
 gnu/packages/radio.scm | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index af6d852a98..0aa8599ca4 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -279,32 +279,27 @@ used by RDS Spy, and audio files containing @dfn{multiplex} signals (MPX).")
 (define-public gnuradio
   (package
     (name "gnuradio")
-    (version "3.8.0.0")
+    (version "3.9.0.0")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://www.gnuradio.org/releases/gnuradio/"
                            "gnuradio-" version ".tar.xz"))
        (sha256
-        (base32 "0aw55gf5549b0fz2qdi7vplcmaf92bj34h40s34b2ycnqasv900r"))
-       (modules '((guix build utils)))
-       (snippet
-        '(begin
-           ;; Delete bundled volk to use the shared one.
-           (delete-file-recursively "volk")
-           #t))))
+	(base32 "1jvm9xd0l2pz1fww4zii6hl7ccnvy256nrf70ljb594n7j9j49ha"))
+       (modules '((guix build utils)))))
     (build-system cmake-build-system)
     (native-inputs
      `(("doxygen" ,doxygen)
        ("ghostscript" ,ghostscript)
        ("orc" ,orc)
        ("pkg-config" ,pkg-config)
+       ("pybind11" ,pybind11)
        ("python-cheetah" ,python-cheetah)
        ("python-mako" ,python-mako)
        ("python-pyzmq" ,python-pyzmq)
        ("python-scipy" ,python-scipy)
        ("python-sphinx" ,python-sphinx)
-       ("swig" ,swig)
        ("texlive" ,(texlive-union (list texlive-amsfonts
                                         texlive-latex-amsmath
                                         ;; TODO: Add newunicodechar.
@@ -349,6 +344,7 @@ used by RDS Spy, and audio files containing @dfn{multiplex} signals (MPX).")
                            (guix build python-build-system))
        #:configure-flags
        '("-DENABLE_INTERNAL_VOLK=OFF")
+       #:tests? #false ;disable tests (some tests fail. gnuradio issue #3871)
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'fix-paths
-- 
2.30.1

Message #8 received at 46842 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: João <jpsimas <at> gmail.com>
Cc: 46842 <at> debbugs.gnu.org
Subject: Re: bug#46842: [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Mon, 01 Mar 2021 16:59:28 +0100

Hi,

João <jpsimas <at> gmail.com> skribis:

>         (uri (string-append "https://www.gnuradio.org/releases/gnuradio/"
>                             "gnuradio-" version ".tar.xz"))
>         (sha256
> -        (base32 "0aw55gf5549b0fz2qdi7vplcmaf92bj34h40s34b2ycnqasv900r"))
> -       (modules '((guix build utils)))
> -       (snippet
> -        '(begin
> -           ;; Delete bundled volk to use the shared one.
> -           (delete-file-recursively "volk")
> -           #t))))

Could you confirm there’s no longer a bundled copy of volk or anything
else?

>         #:configure-flags
>         '("-DENABLE_INTERNAL_VOLK=OFF")
> +       #:tests? #false ;disable tests (some tests fail. gnuradio issue #3871)

Could you (1) write the full URL of the issue, and (2) skip only
selected tests instead of disabling tests wholesale?

Bonus points if you write a ChangeLog-style commit log.  :-)

Thanks in advance!

Ludo’.

Message #11 received at 46842 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: João <jpsimas <at> gmail.com>
Cc: 46842 <at> debbugs.gnu.org
Subject: Re: bug#46842: [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Thu, 11 Mar 2021 23:12:39 +0100

Ping!  :-)

Ludovic Courtès <ludo <at> gnu.org> skribis:

> Hi,
>
> João <jpsimas <at> gmail.com> skribis:
>
>>         (uri (string-append "https://www.gnuradio.org/releases/gnuradio/"
>>                             "gnuradio-" version ".tar.xz"))
>>         (sha256
>> -        (base32 "0aw55gf5549b0fz2qdi7vplcmaf92bj34h40s34b2ycnqasv900r"))
>> -       (modules '((guix build utils)))
>> -       (snippet
>> -        '(begin
>> -           ;; Delete bundled volk to use the shared one.
>> -           (delete-file-recursively "volk")
>> -           #t))))
>
> Could you confirm there’s no longer a bundled copy of volk or anything
> else?
>
>>         #:configure-flags
>>         '("-DENABLE_INTERNAL_VOLK=OFF")
>> +       #:tests? #false ;disable tests (some tests fail. gnuradio issue #3871)
>
> Could you (1) write the full URL of the issue, and (2) skip only
> selected tests instead of disabling tests wholesale?
>
> Bonus points if you write a ChangeLog-style commit log.  :-)
>
> Thanks in advance!
>
> Ludo’.

Message #14 received at 46842 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: João Pedro Simas <jpsimas <at> gmail.com>
Cc: 46842 <at> debbugs.gnu.org
Subject: Re: bug#46842: [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Sun, 21 Mar 2021 23:40:14 +0100

[Message part 1 (text/plain, inline)]

Hi,

João Pedro Simas <jpsimas <at> gmail.com> skribis:

> Hi,
> Sorry, this took a bit more time than I expected, but now I think I've
> figured it out.
>
> About the bundled copy of volk, it was removed in this commit
> https://github.com/gnuradio/gnuradio/commit/80c04479da962d048d41165081b026aafdaa0316,
> that is included in 3.9.0.0. I've also removed the:
>>         '("-DENABLE_INTERNAL_VOLK=OFF")
> configure-flag because the env var is not used anymore in gnuradio.

OK.

> I've also added the urls of the issues concerning the tests, but, in the
> end, I found that one of the tests (qa_dtv) was failing due to sdl not
> being included as an input and there, so I've included it, and that there's
> another test that fails, but intermittently (qa_packet_headerparser_b) so I
> disabled it in addition to the original one (qa_header_payload_demux).
>
> I also realized I had forgotten to add a change to the patch file related
> to the lines that patch the references to codec2 inside a swig file that
> was removed in 3.9, because swig was replaced with pybind11. I've added
> that too.
>
> Finally, I wrote the changelog in the commit log. The updated patch file is
> attached.

The patch LGTM but I got this one ‘qa_dtv’ test failure on x86_64:

--8<---------------cut here---------------start------------->8---
222/241 Test #226: qa_cvsd_vocoder ..............................   Passed    1.18 sec
        Start 230: qa_ulaw_vocoder
223/241 Test #228: qa_g723_24_vocoder ...........................   Passed    0.93 sec
        Start 231: qa_codec2_vocoder
224/241 Test #218: qa_dtv .......................................***Failed    3.73 sec
F
======================================================================
FAIL: test_000 (__main__.test_dtv)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gr-dtv/python/dtv/qa_dtv.py", line 171, in test_000
    self.assertFloatTuplesAlmostEqual(out_data, expected_data, 5)
  File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gnuradio-runtime/python/gnuradio/gr_unittest.py", line 96, in assertFloatTuplesAlmostEqual
    return all([
  File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gnuradio-runtime/python/gnuradio/gr_unittest.py", line 97, in <listcomp>
    self.assertAlmostEqual(x, y, places, msg)
AssertionError: -0.0002739299 != -0.0011434406 within 5 places (0.0008695107 difference)

----------------------------------------------------------------------
Ran 1 test in 2.559s

FAILED (failures=1)
--8<---------------cut here---------------end--------------->8---

Does that ring a bell?

Attached is a variant of the patch where I adjusted indentation to
follow our conventions.

BTW, please send patches as attachments in the future (this one had been
mangled on its way).

Thanks,
Ludo’.

PS: Please keep the bug Cc’d.

[0001-gnu-gnuradio-Update-to-3.9.0.0.patch (text/x-patch, attachment)]

Message #17 received at 46842 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: João Pedro Simas <jpsimas <at> gmail.com>,
 46842 <at> debbugs.gnu.org
Subject: Re: [bug#46842] [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Mon, 22 Mar 2021 11:46:47 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> skribis:

> The patch LGTM but I got this one ‘qa_dtv’ test failure on x86_64:
>
> --8<---------------cut here---------------start------------->8---
> 222/241 Test #226: qa_cvsd_vocoder ..............................   Passed    1.18 sec
>         Start 230: qa_ulaw_vocoder
> 223/241 Test #228: qa_g723_24_vocoder ...........................   Passed    0.93 sec
>         Start 231: qa_codec2_vocoder
> 224/241 Test #218: qa_dtv .......................................***Failed    3.73 sec
> F
> ======================================================================
> FAIL: test_000 (__main__.test_dtv)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gr-dtv/python/dtv/qa_dtv.py", line 171, in test_000
>     self.assertFloatTuplesAlmostEqual(out_data, expected_data, 5)
>   File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gnuradio-runtime/python/gnuradio/gr_unittest.py", line 96, in assertFloatTuplesAlmostEqual
>     return all([
>   File "/tmp/guix-build-gnuradio-3.9.0.0.drv-0/gnuradio-3.9.0.0/gnuradio-runtime/python/gnuradio/gr_unittest.py", line 97, in <listcomp>
>     self.assertAlmostEqual(x, y, places, msg)
> AssertionError: -0.0002739299 != -0.0011434406 within 5 places (0.0008695107 difference)
>
> ----------------------------------------------------------------------
> Ran 1 test in 2.559s
>
> FAILED (failures=1)
> --8<---------------cut here---------------end--------------->8---
>
> Does that ring a bell?

Hi,

I just tested this patch, and I don't reproduce the issue with the
qa_dtv test. Does it fail every time on your machine?

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 46842 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: João Pedro Simas <jpsimas <at> gmail.com>,
 46842 <at> debbugs.gnu.org
Subject: Re: [bug#46842] [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Tue, 23 Mar 2021 11:33:19 +0100

Hi,

Guillaume Le Vaillant <glv <at> posteo.net> skribis:

> I just tested this patch, and I don't reproduce the issue with the
> qa_dtv test. Does it fail every time on your machine?

I just tried once, so perhaps it’s a transient failure?  If it sounds
good to you Guillaume, feel free to push.

Thanks,
Ludo’.

Message #25 received at 46842-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 46842-done <at> debbugs.gnu.org,
 João Pedro Simas <jpsimas <at> gmail.com>
Subject: Re: [bug#46842] [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Wed, 24 Mar 2021 12:10:27 +0100

[Message part 1 (text/plain, inline)]

I added a copyright line, tweaked the commit message and pushed the
patch as 083809229bf199399c33b072056be77dbfd75555.
In the following commits, I updated/fixed some packages depending on
gnuradio to make them work with the new version.

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 46842-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 46842-done <at> debbugs.gnu.org,
 João Pedro Simas <jpsimas <at> gmail.com>
Subject: Re: [bug#46842] [PATCH] gnu: gnuradio: Updated to 3.9.0.0.
Date: Wed, 24 Mar 2021 17:17:48 +0100

Guillaume Le Vaillant <glv <at> posteo.net> skribis:

> I added a copyright line, tweaked the commit message and pushed the
> patch as 083809229bf199399c33b072056be77dbfd75555.
> In the following commits, I updated/fixed some packages depending on
> gnuradio to make them work with the new version.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.