GNU bug report logs - #46832
[PATCH] import: hackage: Accept optional version paramter.

Previous Next

Package: guix-patches;

Reported by: Xinglu Chen <public <at> yoctocell.xyz>

Date: Sun, 28 Feb 2021 17:37:01 UTC

Severity: normal

Tags: patch

Merged with 46833

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 46832 in the body.
You can then email your comments to 46832 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#46832; Package guix-patches. (Sun, 28 Feb 2021 17:37:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Xinglu Chen <public <at> yoctocell.xyz>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 28 Feb 2021 17:37:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: hackage: Accept optional version paramter.
Date: Sun, 28 Feb 2021 17:16:10 +0100

* guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
  Make REPO a key.
---
Looks like Martin forgot to update the Hackage importer in commit
bea3b17739fc591b8cf6db1f8d28a6f6c9585577.

 guix/import/hackage.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 6ca4f65cb0..9f992ffe8e 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -344,8 +344,8 @@ respectively."
   (memoize hackage->guix-package))
 
 (define* (hackage-recursive-import package-name . args)
-  (recursive-import package-name #f
-                    #:repo->guix-package (lambda (name repo)
+  (recursive-import package-name
+                    #:repo->guix-package (lambda* (name #:key repo version)
                                            (apply hackage->guix-package/m
                                                   (cons name args)))
                     #:guix-name hackage-name->package-name))
-- 
2.30.0
Merged 46832 46833. Request was from Ludovic Courtès <ludo <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 01 Mar 2021 16:00:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 30 Mar 2021 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 86 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.