GNU bug report logs - #45977
[PATCH 0/1] gnu: guile-redis: Update to 2.0.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 45977 in the body.
You can then email your comments to 45977 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: guix-patches <at> gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, marius <at> gnu.org
Subject: [PATCH 0/1] gnu: guile-redis: Update to 2.0.0.
Date: Tue, 19 Jan 2021 01:39:25 +0300

Hi! Find attached an update to guile-redis that adds proper support for Redis
Pub/Sub.

BonfaceKilz (1):
  gnu: guile-redis: Update to 2.0.0.

 gnu/packages/guile-xyz.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.29.2

Message #10 received at 45977 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: BonfaceKilz <me <at> bonfacemunyoki.com>
Cc: 45977 <at> debbugs.gnu.org
Subject: Re: [bug#45977] [PATCH 0/1] gnu: guile-redis: Update to 2.0.0.
Date: Tue, 19 Jan 2021 21:26:14 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jan 19, 2021 at 01:39:25AM +0300, BonfaceKilz wrote:
> Hi! Find attached an update to guile-redis that adds proper support for Redis
> Pub/Sub.
> 
> BonfaceKilz (1):
>   gnu: guile-redis: Update to 2.0.0.
> 
>  gnu/packages/guile-xyz.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

This update breaks guile2.0-redis. The configure script still checks for
2.0 so I'm not sure if that's intentional. Can you look into it?

Alternatively, I'm not seeing guile2.0-redis used by any packages in
guix, but I'm not sure about just dropping it.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 45977 <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 45977 <at> debbugs.gnu.org
Subject: Re: [bug#45977] [PATCH 0/1] gnu: guile-redis: Update to 2.0.0.
Date: Wed, 20 Jan 2021 09:47:20 +0300

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Tue, Jan 19, 2021 at 01:39:25AM +0300, BonfaceKilz wrote:
>> Hi! Find attached an update to guile-redis that adds proper support for Redis
>> Pub/Sub.
>> 
>> BonfaceKilz (1):
>>   gnu: guile-redis: Update to 2.0.0.
>> 
>>  gnu/packages/guile-xyz.scm | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>> 
>
> This update breaks guile2.0-redis. The configure script still checks for
> 2.0 so I'm not sure if that's intentional. Can you look into it?
>

Yep. Let me dig into it.

> Alternatively, I'm not seeing guile2.0-redis used by any packages in
> guix, but I'm not sure about just dropping it.

Let's not drop it just yet...
-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Humble GNU Emacs User / Bearer of scheme-y parens
Curator: <https://upbookclub.com> / Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 45977 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 45977 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, efraim <at> flashner.co.il
Subject: [PATCH v2 0/2] gnu: guile-redis: Update to 2.0.0.
Date: Tue, 26 Jan 2021 13:42:31 +0300

Hi! For this patch, I've downgraded guile2.0-redis back to 1.3.0. The problem
with with trying to build v2.0.0 on guile2.0 is that libs like (ice-9
textual-ports) were not yet present; but are used in v2.0 of
guile-redis. Here's what I have when I get into a guile2.0 repl:

#+begin_src 
➜  guix git:(master) ✗ guix environment -C --ad-hoc guile <at> 2.0.14 -- guile
The following derivation will be built:
   /gnu/store/f6pxq82f7ifzxmlaba72x0mn9rqfdf8b-profile.drv
The following profile hooks will be built:
   /gnu/store/3ghqadnzhddgcf8nljfzjrkyzvizn61m-manual-database.drv
   /gnu/store/4p7wnbk6bh9g6q1wlb48zmf09rlnwdxl-info-dir.drv
   /gnu/store/4q08ispks919baxrvp5g7wyipn1n98lc-fonts-dir.drv
   /gnu/store/f15hk17knzla3wzhmfyx61lwih1g5mjq-ca-certificate-bundle.drv
building CA certificate bundle...
building fonts directory...
building directory of Info manuals...
building database for manual pages...
building profile with 1 package...
GNU Guile 2.0.14
Copyright (C) 1995-2016 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> ,use (ice-9 textual-ports)
While executing meta-command:
ERROR: no code for module (ice-9 textual-ports)
scheme@(guile-user)> 
#+end_src

In this patch set, I've downgraded the guile2.0-redis version to 1.3.0.

BonfaceKilz (2):
  gnu: guile-redis: Update to 2.0.0.
  gnu: guile2.0-redis: Revert to 1.3.0.

 gnu/packages/guile-xyz.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

-- 
2.29.2

Message #19 received at 45977 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 45977 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, efraim <at> flashner.co.il
Subject: [PATCH v2 1/2] gnu: guile-redis: Update to 2.0.0.
Date: Tue, 26 Jan 2021 13:42:32 +0300

* gnu/packages/guile-xyz.scm (guile-redis): Update to 2.0.0.
---
 gnu/packages/guile-xyz.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c2d853f006..ac260c804b 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2020 Mike Rosset <mike.rosset <at> gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler <at> student.tugraz.at>
 ;;; Copyright © 2020 pukkamustard <pukkamustard <at> posteo.net>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2430,7 +2431,7 @@ interface for reading articles in any format.")
 (define-public guile-redis
   (package
     (name "guile-redis")
-    (version "1.3.0")
+    (version "2.0.0")
     (home-page "https://github.com/aconchillo/guile-redis")
     (source (origin
               (method git-fetch)
@@ -2440,7 +2441,7 @@ interface for reading articles in any format.")
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "14izs8daxh7pb7vwpxi5g427qa31137jkaxrb1cy5rpjkwchy723"))))
+                "1zk2x37lw6ygf7rwy71svnsian8lj51axpxmm66ah7dazn69swlm"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("autoconf" ,autoconf)
-- 
2.29.2

Message #22 received at 45977 <at> debbugs.gnu.org (full text, mbox):

From: BonfaceKilz <me <at> bonfacemunyoki.com>
To: 45977 <at> debbugs.gnu.org
Cc: BonfaceKilz <me <at> bonfacemunyoki.com>, efraim <at> flashner.co.il
Subject: [PATCH v2 2/2] gnu: guile2.0-redis: Revert to 1.3.0.
Date: Tue, 26 Jan 2021 13:42:33 +0300

`(ice-9 textual-ports)` is not present in guile 2.0.x thereby breaking the
build.
---
 gnu/packages/guile-xyz.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index ac260c804b..55551d3b15 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2464,7 +2464,17 @@ key-value cache and store.")
 (define-public guile2.0-redis
   (package
     (inherit guile-redis)
+    (version "1.3.0")
     (name "guile2.0-redis")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/aconchillo/guile-redis")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "14izs8daxh7pb7vwpxi5g427qa31137jkaxrb1cy5rpjkwchy723"))))
     (native-inputs `(("guile" ,guile-2.0)
                      ,@(alist-delete "guile"
                                      (package-native-inputs guile-redis))))))
-- 
2.29.2

Message #27 received at 45977-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: BonfaceKilz <me <at> bonfacemunyoki.com>
Cc: 45977-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/2] gnu: guile-redis: Update to 2.0.0.
Date: Wed, 27 Jan 2021 11:21:37 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jan 26, 2021 at 01:42:31PM +0300, BonfaceKilz wrote:
> Hi! For this patch, I've downgraded guile2.0-redis back to 1.3.0. The problem
> with with trying to build v2.0.0 on guile2.0 is that libs like (ice-9
> textual-ports) were not yet present; but are used in v2.0 of
> guile-redis. Here's what I have when I get into a guile2.0 repl:

I dug into it a bit more and it looks like (redis utils) imports (ice-9
textual-imports) only for the put-string function. If I remove the
import then guile2.0-redis compiles just fine, but I wasn't sure if
there was a good test for it.

(ins)efraim <at> 3900XT ~$ guix environment --ad-hoc guile <at> 2.0 -- guile
;;; WARNING: loading compiled file /home/efraim/.guix-profile/lib/guile/3.0/site-ccache/ice-9/readline.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01�\x00\x00\x00\x00\x00\x00\x00\x00"
;;; WARNING: loading compiled file /run/current-system/profile/lib/guile/3.0/site-ccache/ice-9/readline.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01�\x00\x00\x00\x00\x00\x00\x00\x00"
Consider installing the 'guile-readline' package for
convenient interactive line editing and input history.

;;; WARNING: loading compiled file /home/efraim/.guix-profile/lib/guile/3.0/site-ccache/ice-9/colorized.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01�\x00\x00\x00\x00\x00\x00\x00\x00"
;;; WARNING: loading compiled file /run/current-system/profile/lib/guile/3.0/site-ccache/ice-9/colorized.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01�\x00\x00\x00\x00\x00\x00\x00\x00"
GNU Guile 2.0.14
Copyright (C) 1995-2016 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (put-string "abcde" %current-output-port)
;;; <stdin>:1:0: warning: possibly unbound variable `put-string'
;;; <stdin>:1:0: warning: possibly unbound variable `%current-output-port'
<unnamed port>:1:0: In procedure #<procedure 7ff4222f48e0 at <current input>:1:0 ()>:
<unnamed port>:1:0: In procedure module-lookup: Unbound variable: put-string

Entering a new prompt.  Type `,bt' for a backtrace or `,q' to continue.
scheme@(guile-user) [1]> ,q
scheme@(guile-user)> (use-modules (rnrs io ports))
scheme@(guile-user)> (put-string "abcde" %current-output-port)
;;; <stdin>:4:0: warning: possibly unbound variable `%current-output-port'
<unnamed port>:4:12: In procedure #<procedure 7ff422266160 at <current input>:4:0 ()>:
<unnamed port>:4:12: In procedure module-lookup: Unbound variable: %current-output-port

Entering a new prompt.  Type `,bt' for a backtrace or `,q' to continue.

Ignoring the errors about %current-output-port, in guile2.0 put-string
is in (rnrs io ports), so it looks like it's safe to substitute (ice-9
textual-ports) for (rnrs io ports) in guile2.0-redis. So I made that
change and dropped your second patch. If someone mentions that
guile2.0-redis <at> 2.0.0 is broken we can revisit :)

> #+begin_src 
> ➜  guix git:(master) ✗ guix environment -C --ad-hoc guile <at> 2.0.14 -- guile
> The following derivation will be built:
>    /gnu/store/f6pxq82f7ifzxmlaba72x0mn9rqfdf8b-profile.drv
> The following profile hooks will be built:
>    /gnu/store/3ghqadnzhddgcf8nljfzjrkyzvizn61m-manual-database.drv
>    /gnu/store/4p7wnbk6bh9g6q1wlb48zmf09rlnwdxl-info-dir.drv
>    /gnu/store/4q08ispks919baxrvp5g7wyipn1n98lc-fonts-dir.drv
>    /gnu/store/f15hk17knzla3wzhmfyx61lwih1g5mjq-ca-certificate-bundle.drv
> building CA certificate bundle...
> building fonts directory...
> building directory of Info manuals...
> building database for manual pages...
> building profile with 1 package...
> GNU Guile 2.0.14
> Copyright (C) 1995-2016 Free Software Foundation, Inc.
> 
> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
> This program is free software, and you are welcome to redistribute it
> under certain conditions; type `,show c' for details.
> 
> Enter `,help' for help.
> scheme@(guile-user)> ,use (ice-9 textual-ports)
> While executing meta-command:
> ERROR: no code for module (ice-9 textual-ports)
> scheme@(guile-user)> 
> #+end_src
> 
> In this patch set, I've downgraded the guile2.0-redis version to 1.3.0.
> 
> BonfaceKilz (2):
>   gnu: guile-redis: Update to 2.0.0.
>   gnu: guile2.0-redis: Revert to 1.3.0.
> 
>  gnu/packages/guile-xyz.scm | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> -- 
> 2.29.2
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 45977-done <at> debbugs.gnu.org (full text, mbox):

From: Bonface Munyoki K. <me <at> bonfacemunyoki.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 45977-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 0/2] gnu: guile-redis: Update to 2.0.0.
Date: Wed, 27 Jan 2021 12:40:31 +0300

[Message part 1 (text/plain, inline)]

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Tue, Jan 26, 2021 at 01:42:31PM +0300, BonfaceKilz wrote:
>> Hi! For this patch, I've downgraded
>> guile2.0-redis back to 1.3.0. The problem
>> with with trying to build v2.0.0 on guile2.0 is
>> that libs like (ice-9
>> textual-ports) were not yet present; but are used in v2.0 of
>> guile-redis. Here's what I have when I get into a guile2.0 repl:
>
> I dug into it a bit more and it looks like (redis
> utils) imports (ice-9
> textual-imports) only for the put-string function. If I remove the
> import then guile2.0-redis compiles just fine, but I wasn't sure if
> there was a good test for it.

Thanks!

[...]

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Humble GNU Emacs User / Bearer of scheme-y parens
Curator: <https://upbookclub.com> / Twitter: @BonfaceKilz

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.