GNU bug report logs - #4578
[PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Jari Aalto <jari.aalto <at> cante.net>
Subject: bug#4578 closed by Glenn Morris <rgm <at> gnu.org> (Re: Bug#4578:
 ispell.el (ispell-get-decoded-string): signal an error if no slot found)
Date: Sat, 17 Oct 2009 03:20:13 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#4578: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found

It has been closed by Glenn Morris <rgm <at> gnu.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Glenn Morris <rgm <at> gnu.org> by
replying to this email.


-- 
4578: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4578
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 4578-done <at> debbugs.gnu.org
Subject: Re: Bug#4578: ispell.el (ispell-get-decoded-string): signal an error if no slot found
Date: Fri, 16 Oct 2009 23:10:38 -0400

Thanks; applied.

[Message part 3 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found
Date: Mon, 28 Sep 2009 14:39:07 +0300

[Message part 4 (text/plain, inline)]

Tags: patch

If the empty slot is not checked, the spell checking breaks in myterious
errors. E.g. flyspell-get-casechars returns nil, which breaks all of
flyspell.

2009-09-28  Jari Aalto  <jari.aalto <at> cante.net>

        * textmodes/ispell.el (ispell-get-decoded-string): signal an error
        if no matching slot is found from `ispell-current-dictionary'

[0001-lisp-textmodes-ispell.el-ispell-get-decoded-string-s.patch (text/x-diff, inline)]

From b301e76fdf3e83de88101891a3cd7ea13f5fba14 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Mon, 28 Sep 2009 14:35:21 +0300
Subject: [PATCH] lisp/textmodes/ispell.el: (ispell-get-decoded-string): signal an error if no slot found


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/textmodes/ispell.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 6d02cf9..729122b 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -1289,7 +1289,8 @@ Protects against bogus binding of `enable-multibyte-characters' in XEmacs."
 (defun ispell-get-decoded-string (n)
   (let* ((slot (or
 		(assoc ispell-current-dictionary ispell-local-dictionary-alist)
-		(assoc ispell-current-dictionary ispell-dictionary-alist)))
+		(assoc ispell-current-dictionary ispell-dictionary-alist)
+		(error "No slot match in ispell-current-dictionary")))
 	 (str (nth n slot)))
     (when (and (> (length str) 0)
 	       (not (multibyte-string-p str)))
-- 
1.6.3.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.