GNU bug report logs - #4578
[PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4578 in the body.
You can then email your comments to 4578 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] Emacs CVS: ispell.el (ispell-get-decoded-string): signal an error if no slot found
Date: Mon, 28 Sep 2009 14:39:07 +0300

[Message part 1 (text/plain, inline)]

Tags: patch

If the empty slot is not checked, the spell checking breaks in myterious
errors. E.g. flyspell-get-casechars returns nil, which breaks all of
flyspell.

2009-09-28  Jari Aalto  <jari.aalto <at> cante.net>

        * textmodes/ispell.el (ispell-get-decoded-string): signal an error
        if no matching slot is found from `ispell-current-dictionary'

[0001-lisp-textmodes-ispell.el-ispell-get-decoded-string-s.patch (text/x-diff, inline)]

From b301e76fdf3e83de88101891a3cd7ea13f5fba14 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Mon, 28 Sep 2009 14:35:21 +0300
Subject: [PATCH] lisp/textmodes/ispell.el: (ispell-get-decoded-string): signal an error if no slot found


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/textmodes/ispell.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/textmodes/ispell.el b/lisp/textmodes/ispell.el
index 6d02cf9..729122b 100644
--- a/lisp/textmodes/ispell.el
+++ b/lisp/textmodes/ispell.el
@@ -1289,7 +1289,8 @@ Protects against bogus binding of `enable-multibyte-characters' in XEmacs."
 (defun ispell-get-decoded-string (n)
   (let* ((slot (or
 		(assoc ispell-current-dictionary ispell-local-dictionary-alist)
-		(assoc ispell-current-dictionary ispell-dictionary-alist)))
+		(assoc ispell-current-dictionary ispell-dictionary-alist)
+		(error "No slot match in ispell-current-dictionary")))
 	 (str (nth n slot)))
     (when (and (> (length str) 0)
 	       (not (multibyte-string-p str)))
-- 
1.6.3.3

Message #10 received at 4578-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 4578-done <at> debbugs.gnu.org
Subject: Re: Bug#4578: ispell.el (ispell-get-decoded-string): signal an error if no slot found
Date: Fri, 16 Oct 2009 23:10:38 -0400

Thanks; applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.