GNU bug report logs - #4577
[PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Subject: bug#4577: marked as done ([PATCH] Emacs CVS: flyspell.el:
 (flyspell-get-word): Correct function argment list according to docstring)
Date: Sat, 17 Oct 2009 03:20:08 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 16 Oct 2009 23:10:33 -0400
with message-id <qjhbtyg1g6.fsf <at> fencepost.gnu.org>
and subject line Re: Bug#4577: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
has caused the Emacs bug report #4577,
regarding [PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
4577: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4577
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
Date: Mon, 28 Sep 2009 14:20:55 +0300

[Message part 3 (text/plain, inline)]

Tags: patch

The documentation of flyspell-get-word reads that there are no required
parameters. All are optional. The patch updates to code according to
docstring.

2009-09-28  Jari Aalto  <jari.aalto <at> cante.net>

        * textmodes/flyspell.el (flyspell-get-word): Correct function argment
        list according to docstring. Parameter `following' is optional
        (flyspell-external-point-words): Remove `nil' argument from call
        to `flyspell-get-word'.
        (flyspell-auto-correct-word): Remove `nil' argument from call to
        `flyspell-get-word'.
        (flyspell-correct-word-before-point): Remove `nil' argument from
        call to `flyspell-get-word'.
        (flyspell-word-search-forward): Remove `nil' argument from call to
        `flyspell-get-word'.
        (flyspell-word-search-backward): Remove `nil' argument from call to
        `flyspell-get-word'.

[0001-lisp-textmodes-flyspell.el-flyspell-get-word-Correct.patch (text/x-diff, inline)]

From a225dd1077da59791bddd77b9f62e43e1c02a9cb Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Mon, 28 Sep 2009 14:18:05 +0300
Subject: [PATCH] lisp/textmodes/flyspell.el: (flyspell-get-word): Correct function argment list according to docstring


Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/textmodes/flyspell.el |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index eff19e6..8ee0220 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -986,7 +986,7 @@ Mostly we check word delimiters."
 	  (inhibit-point-motion-hooks t)
 	  p)
       (while (and (not r) (setq p (search-backward word bound t)))
-	(let ((lw (flyspell-get-word '())))
+	(let ((lw (flyspell-get-word)))
 	  (if (and (consp lw) (string-equal (car lw) word))
 	      (setq r p)
 	    (goto-char p))))
@@ -1001,7 +1001,7 @@ Mostly we check word delimiters."
 	  (inhibit-point-motion-hooks t)
 	  p)
       (while (and (not r) (setq p (search-forward word bound t)))
-	(let ((lw (flyspell-get-word '())))
+	(let ((lw (flyspell-get-word))
 	  (if (and (consp lw) (string-equal (car lw) word))
 	      (setq r p)
 	    (goto-char (1+ p)))))
@@ -1250,7 +1250,7 @@ this function changes the last char of the `ispell-casechars' string."
 ;;*---------------------------------------------------------------------*/
 ;;*    flyspell-get-word ...                                            */
 ;;*---------------------------------------------------------------------*/
-(defun flyspell-get-word (following &optional extra-otherchars)
+(defun flyspell-get-word (&optional following extra-otherchars)
   "Return the word for spell-checking according to Ispell syntax.
 If optional argument FOLLOWING is non-nil or if `flyspell-following-word'
 is non-nil when called interactively, then the following word
@@ -1394,7 +1394,7 @@ The buffer to mark them in is `flyspell-large-region-buffer'."
 			      ;; Move back into the match
 			      ;; so flyspell-get-word will find it.
 			      (forward-char -1)
-			      (flyspell-get-word nil)))
+			      (flyspell-get-word)))
 			   (found (car found-list))
 			   (found-length (length found))
 			   (misspell-length (length word)))
@@ -1887,7 +1887,7 @@ This command proposes various successive corrections for the current word."
 	  (flyspell-ajust-cursor-point pos (point) old-max)
 	  (setq flyspell-auto-correct-pos (point)))
       ;; fetch the word to be checked
-      (let ((word (flyspell-get-word nil)))
+      (let ((word (flyspell-get-word)))
 	(if (consp word)
 	    (let ((start (car (cdr word)))
 		  (end (car (cdr (cdr word))))
@@ -2049,7 +2049,7 @@ If OPOINT is non-nil, restore point there after adjusting it for replacement."
   (flyspell-accept-buffer-local-defs)
   (or opoint (setq opoint (point)))
   (let ((cursor-location (point))
-	(word (flyspell-get-word nil)))
+	(word (flyspell-get-word)))
     (if (consp word)
 	(let ((start (car (cdr word)))
 	      (end (car (cdr (cdr word))))
-- 
1.6.3.3

[Message part 5 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 4577-done <at> debbugs.gnu.org
Subject: Re: Bug#4577: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
Date: Fri, 16 Oct 2009 23:10:33 -0400

Thanks; applied (with paren typo corrected).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.